Skip to content

Commit 81dc21b

Browse files
authored
fix(query-builder): Remove [me,my_teams,none] suggestion from assigned (#72915)
We want to keep this as a suggestion for the old search bar, but for the new one we need to remove it because it handles multiple selection differently.
1 parent 28928e1 commit 81dc21b

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

static/app/utils/withIssueTags.tsx

+11-3
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,16 @@ function withIssueTags<Props extends WithIssueTagsProps>(
6161
.filter(team => !team.isMember)
6262
.map(team => `#${team.slug}`);
6363

64-
const meAndMyTeamsNone = ['my_teams', 'none', '[me, my_teams, none]'];
65-
const suggestedAssignees: string[] = ['me', ...meAndMyTeamsNone, ...userTeams];
64+
const suggestedAssignees: string[] = [
65+
'me',
66+
'my_teams',
67+
'none',
68+
// New search builder only works with single value suggestions
69+
...(props.organization.features.includes('issue-stream-search-query-builder')
70+
? []
71+
: ['[me, my_teams, none]']),
72+
...userTeams,
73+
];
6674
const assigndValues: SearchGroup[] | string[] = [
6775
{
6876
title: t('Suggested Values'),
@@ -96,7 +104,7 @@ function withIssueTags<Props extends WithIssueTagsProps>(
96104
values: assigndValues,
97105
},
98106
};
99-
}, [teams, members, tags]);
107+
}, [members, teams, props.organization.features, tags]);
100108

101109
// Listen to tag store updates and cleanup listener on unmount
102110
useEffect(() => {

0 commit comments

Comments
 (0)