Skip to content

Commit 92bb06d

Browse files
authored
feat(issue-search): Update suggested issue.type values to include all issue types (#83529)
Many of the newer issue types were missing. Modifies the logic so that it iterates over the full enum (filtering out some experimental types) to ensure that this stays up to date.
1 parent f0efa23 commit 92bb06d

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

Diff for: static/app/types/group.tsx

+13
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,18 @@ export enum IssueType {
104104
REPLAY_HYDRATION_ERROR = 'replay_hydration_error',
105105
}
106106

107+
// Update this if adding an issue type that you don't want to show up in search!
108+
export const VISIBLE_ISSUE_TYPES = Object.values(IssueType).filter(
109+
type =>
110+
![
111+
IssueType.PROFILE_FRAME_DROP_EXPERIMENTAL,
112+
IssueType.PROFILE_FUNCTION_REGRESSION_EXPERIMENTAL,
113+
].includes(type)
114+
);
115+
107116
export enum IssueTitle {
117+
ERROR = 'Error',
118+
108119
// Performance
109120
PERFORMANCE_CONSECUTIVE_DB_QUERIES = 'Consecutive DB Queries',
110121
PERFORMANCE_CONSECUTIVE_HTTP = 'Consecutive HTTP',
@@ -136,6 +147,8 @@ export enum IssueTitle {
136147
}
137148

138149
const ISSUE_TYPE_TO_ISSUE_TITLE = {
150+
error: IssueTitle.ERROR,
151+
139152
performance_consecutive_db_queries: IssueTitle.PERFORMANCE_CONSECUTIVE_DB_QUERIES,
140153
performance_consecutive_http: IssueTitle.PERFORMANCE_CONSECUTIVE_HTTP,
141154
performance_file_io_main_thread: IssueTitle.PERFORMANCE_FILE_IO_MAIN_THREAD,

Diff for: static/app/views/issueList/utils/useFetchIssueTags.tsx

+2-15
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ import {useLegacyStore} from 'sentry/stores/useLegacyStore';
1414
import {
1515
getIssueTitleFromType,
1616
IssueCategory,
17-
IssueType,
1817
PriorityLevel,
1918
type Tag,
2019
type TagCollection,
20+
VISIBLE_ISSUE_TYPES,
2121
} from 'sentry/types/group';
2222
import type {Organization} from 'sentry/types/organization';
2323
import type {User} from 'sentry/types/user';
@@ -267,20 +267,7 @@ function builtInIssuesFields(
267267
[FieldKey.ISSUE_TYPE]: {
268268
...PREDEFINED_FIELDS[FieldKey.ISSUE_TYPE]!,
269269
name: 'Issue Type',
270-
values: [
271-
IssueType.PERFORMANCE_N_PLUS_ONE_DB_QUERIES,
272-
IssueType.PERFORMANCE_N_PLUS_ONE_API_CALLS,
273-
IssueType.PERFORMANCE_CONSECUTIVE_DB_QUERIES,
274-
IssueType.PERFORMANCE_SLOW_DB_QUERY,
275-
IssueType.PERFORMANCE_RENDER_BLOCKING_ASSET,
276-
IssueType.PERFORMANCE_UNCOMPRESSED_ASSET,
277-
IssueType.PERFORMANCE_ENDPOINT_REGRESSION,
278-
IssueType.PROFILE_FILE_IO_MAIN_THREAD,
279-
IssueType.PROFILE_IMAGE_DECODE_MAIN_THREAD,
280-
IssueType.PROFILE_JSON_DECODE_MAIN_THREAD,
281-
IssueType.PROFILE_REGEX_MAIN_THREAD,
282-
IssueType.PROFILE_FUNCTION_REGRESSION,
283-
].map(value => ({
270+
values: VISIBLE_ISSUE_TYPES.map(value => ({
284271
icon: null,
285272
title: value,
286273
name: value,

0 commit comments

Comments
 (0)