finally fixing slack sql and adding more tests for sentry app email

Author: chloeho7

src/sentry/web/frontend/debug/debug_notify_disable.py

@@ -13,7 +13,6 @@ def get(self, request: HttpRequest) -> HttpResponse:
         self.integration = Integration.objects.create(
             provider="slack",
             name="Awesome Team",
-            external_id="TXXXXXXX",
             metadata={
                 "access_token": "xoxb-xxxxxxxxx-xxxxxxxxxx-xxxxxxxxxxxx",
                 "installation_type": "born_as_bot",

src/sentry/web/frontend/debug/debug_sentry_app_notify_disable.py

@@ -3,30 +3,33 @@
 
 from sentry.constants import SentryAppStatus
 from sentry.integrations.notify_disable import get_provider_type, get_url
-from sentry.models import Organization, SentryApp
+from sentry.models import Organization, SentryApp, SentryAppInstallation
 
 from .mail import MailPreview
 
 
 class DebugSentryAppNotifyDisableView(View):
     def get(self, request: HttpRequest) -> HttpResponse:
 
-        self.organization = Organization(id=1, slug="organization", name="My Company")
+        self.organization = Organization(id=1, slug="sentry", name="My Company")
         self.sentry_app = SentryApp(
             name="Test App",
             events=["issue.resolved", "issue.ignored", "issue.assigned"],
             status=SentryAppStatus.INTERNAL,
             webhook_url="https://broken-example.com/webhook",
+            slug="internal-35e455",
+        )
+        self.install = SentryAppInstallation(
+            organization_id=self.organization.id, sentry_app=self.sentry_app
         )
 
+        redis_key = f"sentry-app-error:{self.install.uuid}"
         integration_name = self.sentry_app.name
         integration_link = get_url(
             self.organization,
-            get_provider_type(f"sentry-app-error:{self.sentry_app.uuid}"),
+            get_provider_type(redis_key),
             self.sentry_app.slug,
         )
-        redis_key = f"sentry-app-error:{self.sentry_app.uuid}"
-
         return MailPreview(
             html_template="sentry/integrations/sentry-app-notify-disable.html",
             text_template="sentry/integrations/sentry-app-notify-disable.txt",

tests/sentry/tasks/test_sentry_apps.py

@@ -647,6 +647,7 @@ def setUp(self):
             name="Test App",
             organization=self.organization,
             events=["issue.resolved", "issue.ignored", "issue.assigned"],
+            webhook_url="https://example.com",
         )
         self.sentry_app.update(status=SentryAppStatus.PUBLISHED)
 
@@ -904,6 +905,7 @@ def test_notify_disabled_email(self):
                 self.sentry_app.name,
                 get_redis_key(self.sentry_app, self.organization.id),
                 self.sentry_app.slug,
+                self.sentry_app.webhook_url,
             )
         assert len(mail.outbox) == 1
         msg = mail.outbox[0]
@@ -917,3 +919,10 @@ def test_notify_disabled_email(self):
             )
             in msg.body
         )
+        assert (
+            self.organization.absolute_url(
+                f"/settings/{self.organization.slug}/developer-settings/{self.sentry_app.slug}/dashboard"
+            )
+            in msg.body
+        )
+        assert (self.sentry_app.webhook_url) in msg.body