Skip to content

Commit 98db829

Browse files
authored
chore(alerts): Drop included and excluded projects (#81250)
Follow up to #81204 to fully remove `excluded_projects` and `include_all_projects` from the `AlertRule` model which was blocking removing the `AlertRuleExcludedProjects` table.
1 parent be87cf8 commit 98db829

File tree

2 files changed

+37
-1
lines changed

2 files changed

+37
-1
lines changed

migrations_lockfile.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ remote_subscriptions: 0003_drop_remote_subscription
1515

1616
replays: 0004_index_together
1717

18-
sentry: 0794_rm_excluded_included_projects_alertrule
18+
sentry: 0795_drop_included_excluded_projects
1919

2020
social_auth: 0002_default_auto_field
2121

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
# Generated by Django 5.1.1 on 2024-11-25 17:33
2+
3+
from sentry.new_migrations.migrations import CheckedMigration
4+
from sentry.new_migrations.monkey.fields import SafeRemoveField
5+
from sentry.new_migrations.monkey.state import DeletionAction
6+
7+
8+
class Migration(CheckedMigration):
9+
# This flag is used to mark that a migration shouldn't be automatically run in production.
10+
# This should only be used for operations where it's safe to run the migration after your
11+
# code has deployed. So this should not be used for most operations that alter the schema
12+
# of a table.
13+
# Here are some things that make sense to mark as post deployment:
14+
# - Large data migrations. Typically we want these to be run manually so that they can be
15+
# monitored and not block the deploy for a long period of time while they run.
16+
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
17+
# run this outside deployments so that we don't block them. Note that while adding an index
18+
# is a schema change, it's completely safe to run the operation after the code has deployed.
19+
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
20+
21+
is_post_deployment = False
22+
23+
dependencies = [
24+
("sentry", "0794_rm_excluded_included_projects_alertrule"),
25+
]
26+
27+
operations = [
28+
SafeRemoveField(
29+
model_name="alertrule", name="excluded_projects", deletion_action=DeletionAction.DELETE
30+
),
31+
SafeRemoveField(
32+
model_name="alertrule",
33+
name="include_all_projects",
34+
deletion_action=DeletionAction.DELETE,
35+
),
36+
]

0 commit comments

Comments
 (0)