feat(discover2): Allow tags to be saved in Saved Queries (#15359)

Author: dashed

src/sentry/api/serializers/models/discoversavedquery.py

@@ -23,6 +23,7 @@ def serialize(self, obj, attrs, user, **kwargs):
             "orderby",
             "limit",
             "version",
+            "tags",
         ]
 
         data = {

src/sentry/discover/endpoints/serializers.py

@@ -160,9 +160,10 @@ class DiscoverSavedQuerySerializer(serializers.Serializer):
     environment = ListField(child=serializers.CharField(), required=False, allow_null=True)
     fieldnames = ListField(child=serializers.CharField(), required=False, allow_null=True)
     query = serializers.CharField(required=False, allow_null=True)
+    tags = ListField(child=serializers.CharField(), required=False, allow_null=True)
 
     disallowed_fields = {
-        1: set(["environment", "fieldnames", "query"]),
+        1: set(["environment", "fieldnames", "query", "tags"]),
         2: set(["groupby", "rollup", "aggregations", "conditions", "limit"]),
     }
 
@@ -198,6 +199,7 @@ def validate(self, data):
             "end",
             "orderby",
             "limit",
+            "tags",
         ]
 
         for key in query_keys:

src/sentry/static/sentry/app/stores/discoverSavedQueriesStore.tsx

@@ -16,6 +16,7 @@ export type NewQuery = {
   start?: string;
   end?: string;
   environment?: Readonly<string[]>;
+  tags?: Readonly<string[]>;
 };
 
 export type SavedQuery = NewQuery & {

src/sentry/static/sentry/app/views/eventsV2/eventView.tsx

@@ -411,7 +411,12 @@ class EventView {
       start: saved.start,
       end: saved.end,
       sorts: fromSorts(saved.orderby),
-      tags: [],
+      tags: collectQueryStringByKey(
+        {
+          tags: (saved as SavedQuery).tags as string[],
+        },
+        'tags'
+      ),
       statsPeriod: saved.range,
       environment: collectQueryStringByKey(
         {
@@ -475,7 +480,7 @@ class EventView {
       fields: this.getFields(),
       fieldnames: this.getFieldNames(),
       orderby,
-      // TODO: tags?
+      tags: this.tags,
       query: this.query || '',
       projects: this.project,
       start: this.start,

tests/js/spec/views/eventsV2/eventView.spec.jsx

@@ -534,6 +534,7 @@ describe('EventView.toNewQuery()', function() {
       end: '2019-10-02T00:00:00',
       range: '14d',
       environment: ['staging'],
+      tags: ['foo', 'bar'],
     };
 
     expect(output).toEqual(expected);
@@ -562,6 +563,7 @@ describe('EventView.toNewQuery()', function() {
       end: '2019-10-02T00:00:00',
       range: '14d',
       environment: ['staging'],
+      tags: ['foo', 'bar'],
     };
 
     expect(output).toEqual(expected);
@@ -590,6 +592,7 @@ describe('EventView.toNewQuery()', function() {
       end: '2019-10-02T00:00:00',
       range: '14d',
       environment: ['staging'],
+      tags: ['foo', 'bar'],
     };
 
     expect(output).toEqual(expected);

tests/snuba/api/endpoints/test_discover_saved_queries.py

@@ -169,6 +169,7 @@ def test_post_success(self):
                     "fieldnames": ["event title", "total", "project"],
                     "query": "event.type:error browser.name:Firefox",
                     "range": "24h",
+                    "tags": ["release", "environment"],
                     "version": 2,
                 },
             )
@@ -179,6 +180,7 @@ def test_post_success(self):
         assert data["range"] == "24h"
         assert data["environment"] == ["dev"]
         assert data["query"] == "event.type:error browser.name:Firefox"
+        assert data["tags"] == ["release", "environment"]
 
     def test_post_success_no_fieldnames(self):
         with self.feature(self.feature_name):