Skip to content

Commit a7454b2

Browse files
asottile-sentryevanh
authored andcommitted
ref: remove requires_not_arm64 (#82093)
these tests pass now on arm64 -- presumably because we no longer have version drift for clickhouse <!-- Describe your PR here. -->
1 parent fac79ff commit a7454b2

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

Diff for: src/sentry/testutils/skips.py

-9
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,6 @@
1212
T = TypeVar("T", bound=Callable[..., Any])
1313

1414

15-
def is_arm64() -> bool:
16-
return os.uname().machine == "arm64"
17-
18-
19-
requires_not_arm64 = pytest.mark.skipif(
20-
is_arm64(), reason="this test fails in our arm64 testing env"
21-
)
22-
23-
2415
def xfail_if_not_postgres(reason: str) -> Callable[[T], T]:
2516
def decorator(function: T) -> T:
2617
return pytest.mark.xfail(os.environ.get("TEST_SUITE") != "postgres", reason=reason)(

Diff for: tests/snuba/api/endpoints/test_organization_events.py

-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
from sentry.testutils.helpers import parse_link_header
3939
from sentry.testutils.helpers.datetime import before_now, freeze_time, iso_format
4040
from sentry.testutils.helpers.discover import user_misery_formula
41-
from sentry.testutils.skips import requires_not_arm64
4241
from sentry.types.group import GroupSubStatus
4342
from sentry.utils import json
4443
from sentry.utils.samples import load_data
@@ -3373,7 +3372,6 @@ def test_all_aggregates_in_columns(self):
33733372
assert data[0]["linear_regression(transaction.duration, transaction.duration)"] == [0, 0]
33743373
assert data[0]["sum(transaction.duration)"] == 10000
33753374

3376-
@requires_not_arm64
33773375
def test_null_user_misery_returns_zero(self):
33783376
self.transaction_data["user"] = None
33793377
self.transaction_data["transaction"] = "/no_users/1"
@@ -3393,7 +3391,6 @@ def test_null_user_misery_returns_zero(self):
33933391
data = response.data["data"]
33943392
assert data[0]["user_misery(300)"] == 0
33953393

3396-
@requires_not_arm64
33973394
def test_null_user_misery_new_returns_zero(self):
33983395
self.transaction_data["user"] = None
33993396
self.transaction_data["transaction"] = "/no_users/1"

0 commit comments

Comments
 (0)