ref: fix types for eventstore.test_base (#82092)

<!-- Describe your PR here. -->

Author: asottile-sentry

Diff for: pyproject.toml

@@ -326,7 +326,6 @@ module = [
     "tests.sentry.api.test_authentication",
     "tests.sentry.api.test_base",
     "tests.sentry.api.test_event_search",
-    "tests.sentry.eventstore.test_base",
     "tests.sentry.issues.test_utils",
 ]
 disable_error_code = [

Diff for: tests/sentry/eventstore/test_base.py

@@ -1,16 +1,9 @@
-import logging
-from unittest import mock
-
-import pytest
-
-from sentry import eventstore
 from sentry.eventstore.base import EventStorage
 from sentry.eventstore.models import Event
 from sentry.snuba.dataset import Dataset
-from sentry.testutils.cases import SnubaTestCase, TestCase
+from sentry.testutils.cases import TestCase
 from sentry.testutils.helpers.datetime import before_now
 from sentry.testutils.skips import requires_snuba
-from sentry.utils.samples import load_data
 
 pytestmark = [requires_snuba]
 
@@ -39,64 +32,9 @@ def test_bind_nodes(self):
 
         event = Event(project_id=self.project.id, event_id="a" * 32)
         event2 = Event(project_id=self.project.id, event_id="b" * 32)
-        assert event.data._node_data is None
+        before = event.data._node_data
         self.eventstorage.bind_nodes([event, event2])
-        assert event.data._node_data is not None
+        after = event.data._node_data
+        assert before is None
+        assert after is not None
         assert event.data["user"]["id"] == "user1"
-
-
-class ServiceDelegationTest(TestCase, SnubaTestCase):
-    def setUp(self):
-        super().setUp()
-        self.min_ago = before_now(minutes=1)
-        self.two_min_ago = before_now(minutes=2)
-        self.project = self.create_project()
-
-        self.event = self.store_event(
-            data={
-                "event_id": "a" * 32,
-                "type": "default",
-                "platform": "python",
-                "fingerprint": ["group1"],
-                "timestamp": self.two_min_ago,
-                "tags": {"foo": "1"},
-            },
-            project_id=self.project.id,
-        )
-
-        event_data = load_data("transaction")
-        event_data["timestamp"] = before_now(minutes=1)
-        event_data["start_timestamp"] = before_now(minutes=1, seconds=1)
-        event_data["event_id"] = "b" * 32
-
-        self.transaction_event = self.store_event(data=event_data, project_id=self.project.id)
-
-    @pytest.mark.skip(reason="There is no longer a difference in underlying dataset.")
-    def test_logs_differences(self):
-        logger = logging.getLogger("sentry.eventstore")
-
-        with mock.patch.object(logger, "info") as mock_logger:
-            # No differences to log
-            _filter = eventstore.Filter(project_ids=[self.project.id])
-            eventstore.backend.get_events(filter=_filter)
-            eventstore.backend.get_event_by_id(self.project.id, "a" * 32)
-            assert mock_logger.call_count == 0
-
-            # Here we expect a difference since the original implementation handles type as a tag
-            event = eventstore.backend.get_event_by_id(self.project.id, "a" * 32)
-            _filter = eventstore.Filter(
-                project_ids=[self.project.id], conditions=[["type", "=", "transaction"]]
-            )
-            eventstore.get_next_event_id(event, _filter)
-            assert mock_logger.call_count == 1
-            mock_logger.assert_called_with(
-                "discover.result-mismatch",
-                extra={
-                    "snuba_result": None,
-                    "snuba_discover_result": (str(self.project.id), "b" * 32),
-                    "method": "get_next_event_id",
-                    "event_id": event.event_id,
-                    "filter_keys": _filter.filter_keys,
-                    "conditions": _filter.conditions,
-                },
-            )