Skip to content

Commit aa232bf

Browse files
committed
add tests
1 parent 8fc05c5 commit aa232bf

File tree

1 file changed

+30
-0
lines changed

1 file changed

+30
-0
lines changed

tests/sentry/event_manager/test_event_manager.py

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2641,6 +2641,36 @@ def test_severity_score_flag_off(self, mock_get_severity_score: MagicMock):
26412641
mock_get_severity_score.assert_not_called()
26422642
assert event.group and "severity" not in event.group.get_event_metadata()
26432643

2644+
@patch("sentry.event_manager._get_severity_score", return_value=None)
2645+
def test_no_severity_score_assigned_when_value_is_None(
2646+
self, mock_get_severity_score: MagicMock
2647+
):
2648+
with self.feature({"projects:first-event-severity-calculation": True}):
2649+
manager = EventManager(
2650+
make_event(
2651+
exception={"values": [{"type": "NopeError", "value": "Nopey McNopeface"}]}
2652+
)
2653+
)
2654+
event = manager.save(self.project.id)
2655+
2656+
mock_get_severity_score.assert_called()
2657+
assert event.group and "severity" not in event.group.get_event_metadata()
2658+
2659+
@patch("sentry.event_manager._get_severity_score", return_value=0)
2660+
def test_severity_score_still_assigned_when_value_is_zero(
2661+
self, mock_get_severity_score: MagicMock
2662+
):
2663+
with self.feature({"projects:first-event-severity-calculation": True}):
2664+
manager = EventManager(
2665+
make_event(
2666+
exception={"values": [{"type": "NopeError", "value": "Nopey McNopeface"}]}
2667+
)
2668+
)
2669+
event = manager.save(self.project.id)
2670+
2671+
mock_get_severity_score.assert_called()
2672+
assert event.group and event.group.get_event_metadata().get("severity") == 0
2673+
26442674

26452675
class AutoAssociateCommitTest(TestCase, EventManagerTestMixin):
26462676
def setUp(self):

0 commit comments

Comments
 (0)