Skip to content

Commit c305695

Browse files
authored
chore(similarity): EA similarity record deletion task (#76331)
Remove random percentage rollout option usage in similarity record deletion task
1 parent 5f8d1a3 commit c305695

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

src/sentry/api/endpoints/project_details.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
import math
33
import time
44
from datetime import timedelta
5-
from random import randint
65
from uuid import uuid4
76

87
import orjson
@@ -14,7 +13,7 @@
1413
from rest_framework.response import Response
1514
from rest_framework.serializers import ListField
1615

17-
from sentry import audit_log, features, options
16+
from sentry import audit_log, features
1817
from sentry.api.api_publish_status import ApiPublishStatus
1918
from sentry.api.base import region_silo_endpoint
2019
from sentry.api.bases.project import ProjectEndpoint, ProjectPermission
@@ -986,10 +985,9 @@ def delete(self, request: Request, project) -> Response:
986985
project.rename_on_pending_deletion()
987986

988987
# Tell seer to delete all the project's grouping records
989-
if features.has("projects:similarity-embeddings-grouping", project) or (
990-
project.get_option("sentry:similarity_backfill_completed")
991-
and randint(1, 100) <= options.get("similarity.delete_task_EA_rollout_percentage")
992-
):
988+
if features.has(
989+
"projects:similarity-embeddings-grouping", project
990+
) or project.get_option("sentry:similarity_backfill_completed"):
993991
call_seer_delete_project_grouping_records.apply_async(args=[project.id])
994992

995993
return Response(status=204)

src/sentry/tasks/delete_seer_grouping_records.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import logging
2-
from random import randint
32
from typing import Any
43

54
from sentry import features, options
@@ -59,10 +58,7 @@ def call_delete_seer_grouping_records_by_hash(
5958
project
6059
and (
6160
features.has("projects:similarity-embeddings-grouping", project)
62-
or (
63-
project.get_option("sentry:similarity_backfill_completed")
64-
and randint(1, 100) <= options.get("similarity.delete_task_EA_rollout_percentage")
65-
)
61+
or project.get_option("sentry:similarity_backfill_completed")
6662
)
6763
and not killswitch_enabled(project.id)
6864
and not options.get("seer.similarity-embeddings-delete-by-hash-killswitch.enabled")

0 commit comments

Comments
 (0)