Skip to content

Commit c490653

Browse files
ref(quick-start): Remove 'New' prefix from components (#83484)
1 parent c06a3aa commit c490653

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

Diff for: static/app/components/onboardingWizard/newSidebar.spec.tsx renamed to static/app/components/onboardingWizard/sidebar.spec.tsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {initializeOrg} from 'sentry-test/initializeOrg';
22
import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
33

4-
import {NewOnboardingSidebar} from 'sentry/components/onboardingWizard/newSidebar';
4+
import {OnboardingSidebar} from 'sentry/components/onboardingWizard/sidebar';
55
import {type OnboardingTask, OnboardingTaskKey} from 'sentry/types/onboarding';
66

77
const gettingStartedTasks: OnboardingTask[] = [
@@ -46,10 +46,10 @@ const beyondBasicsTasks: OnboardingTask[] = [
4646
},
4747
];
4848

49-
describe('NewSidebar', function () {
49+
describe('Sidebar', function () {
5050
it('should render the sidebar with the correct groups and tasks', async function () {
5151
render(
52-
<NewOnboardingSidebar
52+
<OnboardingSidebar
5353
onClose={jest.fn()}
5454
orientation="left"
5555
collapsed={false}
@@ -83,7 +83,7 @@ describe('NewSidebar', function () {
8383

8484
it('if first group completed, second group should be expanded by default', function () {
8585
render(
86-
<NewOnboardingSidebar
86+
<OnboardingSidebar
8787
onClose={jest.fn()}
8888
orientation="left"
8989
collapsed={false}
@@ -114,7 +114,7 @@ describe('NewSidebar', function () {
114114
});
115115

116116
render(
117-
<NewOnboardingSidebar
117+
<OnboardingSidebar
118118
onClose={jest.fn()}
119119
orientation="left"
120120
collapsed={false}

Diff for: static/app/components/onboardingWizard/newSidebar.tsx renamed to static/app/components/onboardingWizard/sidebar.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ function TaskGroup({
557557
);
558558
}
559559

560-
interface NewSidebarProps
560+
interface SidebarProps
561561
extends Pick<CommonSidebarProps, 'orientation' | 'collapsed'>,
562562
Pick<
563563
ReturnType<typeof useOnboardingTasks>,
@@ -566,13 +566,13 @@ interface NewSidebarProps
566566
onClose: () => void;
567567
}
568568

569-
export function NewOnboardingSidebar({
569+
export function OnboardingSidebar({
570570
onClose,
571571
orientation,
572572
collapsed,
573573
gettingStartedTasks,
574574
beyondBasicsTasks,
575-
}: NewSidebarProps) {
575+
}: SidebarProps) {
576576
const walkthrough = isDemoModeEnabled();
577577

578578
const sortedGettingStartedTasks = gettingStartedTasks.sort(

Diff for: static/app/components/sidebar/index.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {
1717
ExpandedContext,
1818
ExpandedContextProvider,
1919
} from 'sentry/components/sidebar/expandedContextProvider';
20-
import {NewOnboardingStatus} from 'sentry/components/sidebar/newOnboardingStatus';
20+
import {OnboardingStatus} from 'sentry/components/sidebar/onboardingStatus';
2121
import {DismissableRollbackBanner} from 'sentry/components/sidebar/rollback/dismissableBanner';
2222
import {isDone} from 'sentry/components/sidebar/utils';
2323
import {
@@ -621,7 +621,7 @@ function Sidebar() {
621621
{...sidebarItemProps}
622622
/>
623623
<SidebarSection hasNewNav={hasNewNav} noMargin noPadding>
624-
<NewOnboardingStatus
624+
<OnboardingStatus
625625
currentPanel={activePanel}
626626
onShowPanel={() => togglePanel(SidebarPanelKey.ONBOARDING_WIZARD)}
627627
hidePanel={hidePanel}

Diff for: static/app/components/sidebar/newOnboardingStatus.spec.tsx renamed to static/app/components/sidebar/onboardingStatus.spec.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {UserFixture} from 'sentry-fixture/user';
33

44
import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
55

6-
import {NewOnboardingStatus} from 'sentry/components/sidebar/newOnboardingStatus';
6+
import {OnboardingStatus} from 'sentry/components/sidebar/onboardingStatus';
77
import {SidebarPanelKey} from 'sentry/components/sidebar/types';
88
import {OnboardingTaskKey} from 'sentry/types/onboarding';
99
import type {Organization} from 'sentry/types/organization';
@@ -40,7 +40,7 @@ describe('Onboarding Status', function () {
4040
const handleShowPanel = jest.fn();
4141

4242
render(
43-
<NewOnboardingStatus
43+
<OnboardingStatus
4444
currentPanel=""
4545
onShowPanel={handleShowPanel}
4646
hidePanel={jest.fn()}
@@ -84,7 +84,7 @@ describe('Onboarding Status', function () {
8484
const handleHidePanel = jest.fn();
8585

8686
render(
87-
<NewOnboardingStatus
87+
<OnboardingStatus
8888
currentPanel={SidebarPanelKey.ONBOARDING_WIZARD}
8989
onShowPanel={jest.fn()}
9090
hidePanel={handleHidePanel}

Diff for: static/app/components/sidebar/newOnboardingStatus.tsx renamed to static/app/components/sidebar/onboardingStatus.tsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {css} from '@emotion/react';
44
import styled from '@emotion/styled';
55

66
import {OnboardingContext} from 'sentry/components/onboarding/onboardingContext';
7-
import {NewOnboardingSidebar} from 'sentry/components/onboardingWizard/newSidebar';
7+
import {OnboardingSidebar} from 'sentry/components/onboardingWizard/sidebar';
88
import {getMergedTasks} from 'sentry/components/onboardingWizard/taskConfig';
99
import {useOnboardingTasks} from 'sentry/components/onboardingWizard/useOnboardingTasks';
1010
import {findCompleteTasks} from 'sentry/components/onboardingWizard/utils';
@@ -26,15 +26,15 @@ import useProjects from 'sentry/utils/useProjects';
2626
import type {CommonSidebarProps} from './types';
2727
import {SidebarPanelKey} from './types';
2828

29-
type NewOnboardingStatusProps = CommonSidebarProps;
29+
type OnboardingStatusProps = CommonSidebarProps;
3030

31-
export function NewOnboardingStatus({
31+
export function OnboardingStatus({
3232
collapsed,
3333
currentPanel,
3434
orientation,
3535
hidePanel,
3636
onShowPanel,
37-
}: NewOnboardingStatusProps) {
37+
}: OnboardingStatusProps) {
3838
const organization = useOrganization();
3939
const onboardingContext = useContext(OnboardingContext);
4040
const {projects} = useProjects();
@@ -148,7 +148,7 @@ export function NewOnboardingStatus({
148148
)}
149149
</Container>
150150
{isActive && (
151-
<NewOnboardingSidebar
151+
<OnboardingSidebar
152152
orientation={orientation}
153153
collapsed={collapsed}
154154
onClose={hidePanel}

0 commit comments

Comments
 (0)