Skip to content

Commit c4a0352

Browse files
mifu67c298lee
authored andcommitted
chore(anomaly detection): surface generic caught exeption (#77192)
Surface info about generic caught exception in the logs
1 parent a295aee commit c4a0352

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/sentry/incidents/serializers/alert_rule.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,11 @@ def create(self, validated_data):
505505
except forms.ValidationError as e:
506506
# if we fail in create_metric_alert, then only one message is ever returned
507507
raise serializers.ValidationError(e.error_list[0].message)
508-
except Exception:
508+
except Exception as e:
509+
logger.exception(
510+
"Error when creating alert rule",
511+
extra={"details": str(e)},
512+
)
509513
raise BadRequest
510514
self._handle_triggers(alert_rule, triggers)
511515
return alert_rule
@@ -533,7 +537,11 @@ def update(self, instance, validated_data):
533537
except forms.ValidationError as e:
534538
# if we fail in update_metric_alert, then only one message is ever returned
535539
raise serializers.ValidationError(e.error_list[0].message)
536-
except Exception:
540+
except Exception as e:
541+
logger.exception(
542+
"Error when updating alert rule",
543+
extra={"details": str(e)},
544+
)
537545
raise BadRequest
538546
self._handle_triggers(alert_rule, triggers)
539547
return alert_rule

0 commit comments

Comments
 (0)