fix typing

Author: Zylphrex

src/sentry/seer/utils.py

@@ -1,9 +1,31 @@
+from typing import List, TypedDict
+
 from django.conf import settings
 from urllib3 import Retry
 
 from sentry.net.http import connection_from_url
 from sentry.utils import json
 
+
+class BreakpointData(TypedDict):
+    project: str
+    # For legacy reasons, the group name is always
+    # transaction even when working with functions.
+    transaction: str
+    aggregate_range_1: float
+    aggregate_range_2: float
+    unweighted_t_value: float
+    unweighted_p_value: float
+    trend_percentage: float
+    absolute_percentage_change: float
+    trend_difference: float
+    breakpoint: int
+
+
+class BreakpointResponse(TypedDict):
+    data: List[BreakpointData]
+
+
 seer_connection_pool = connection_from_url(
     settings.ANOMALY_DETECTION_URL,
     retries=Retry(
@@ -14,7 +36,7 @@
 )
 
 
-def detect_breakpoints(breakpoint_request):
+def detect_breakpoints(breakpoint_request) -> BreakpointResponse:
     response = seer_connection_pool.urlopen(
         "POST",
         "/trends/breakpoint-detector",

src/sentry/tasks/statistical_detectors.py

@@ -29,7 +29,7 @@
 from sentry.search.events.builder import ProfileTopFunctionsTimeseriesQueryBuilder
 from sentry.search.events.fields import get_function_alias
 from sentry.search.events.types import QueryBuilderConfig
-from sentry.seer.utils import detect_breakpoints
+from sentry.seer.utils import BreakpointData, detect_breakpoints
 from sentry.sentry_metrics import indexer
 from sentry.sentry_metrics.use_case_id_registry import UseCaseID
 from sentry.snuba import functions
@@ -249,7 +249,10 @@ def _detect_function_trends(
     )
 
 
-def _detect_function_change_points(functions_list: List[Tuple[int, int]], start: datetime) -> None:
+def _detect_function_change_points(
+    functions_list: List[Tuple[int, int]],
+    start: datetime,
+) -> Generator[BreakpointData, None, None]:
     serializer = SnubaTSResultSerializer(None, None, None)
 
     trend_function = "p95()"