Skip to content

Commit d65af5b

Browse files
feat(alerts): Limits eap alert time windows and periods (#81916)
Updates EAP alerts to only allow up to 2016 buckets queried in the visualization. - Removes 14 day visualizations - Removes 1 minute intervals
1 parent 724c48d commit d65af5b

File tree

2 files changed

+35
-0
lines changed

2 files changed

+35
-0
lines changed

Diff for: static/app/views/alerts/rules/metric/ruleConditionsForm.tsx

+13
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,19 @@ class RuleConditionsForm extends PureComponent<Props, State> {
288288
]);
289289
}
290290

291+
if (this.props.dataset === Dataset.EVENTS_ANALYTICS_PLATFORM) {
292+
options = pick(TIME_WINDOW_MAP, [
293+
TimeWindow.FIVE_MINUTES,
294+
TimeWindow.TEN_MINUTES,
295+
TimeWindow.FIFTEEN_MINUTES,
296+
TimeWindow.THIRTY_MINUTES,
297+
TimeWindow.ONE_HOUR,
298+
TimeWindow.TWO_HOURS,
299+
TimeWindow.FOUR_HOURS,
300+
TimeWindow.ONE_DAY,
301+
]);
302+
}
303+
291304
return Object.entries(options).map(([value, label]) => ({
292305
value: parseInt(value, 10),
293306
label: tct('[timeWindow] interval', {

Diff for: static/app/views/alerts/rules/metric/triggers/chart/index.tsx

+22
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,24 @@ export const AVAILABLE_TIME_PERIODS: Record<TimeWindow, readonly TimePeriod[]> =
138138
[TimeWindow.ONE_DAY]: [TimePeriod.FOURTEEN_DAYS],
139139
};
140140

141+
const MOST_EAP_TIME_PERIOD = [
142+
TimePeriod.ONE_DAY,
143+
TimePeriod.THREE_DAYS,
144+
TimePeriod.SEVEN_DAYS,
145+
];
146+
147+
const EAP_AVAILABLE_TIME_PERIODS = {
148+
[TimeWindow.ONE_MINUTE]: [], // One minute intervals are not allowed on EAP Alerts
149+
[TimeWindow.FIVE_MINUTES]: MOST_EAP_TIME_PERIOD,
150+
[TimeWindow.TEN_MINUTES]: MOST_EAP_TIME_PERIOD,
151+
[TimeWindow.FIFTEEN_MINUTES]: MOST_EAP_TIME_PERIOD,
152+
[TimeWindow.THIRTY_MINUTES]: MOST_EAP_TIME_PERIOD,
153+
[TimeWindow.ONE_HOUR]: MOST_EAP_TIME_PERIOD,
154+
[TimeWindow.TWO_HOURS]: MOST_EAP_TIME_PERIOD,
155+
[TimeWindow.FOUR_HOURS]: [TimePeriod.SEVEN_DAYS],
156+
[TimeWindow.ONE_DAY]: [TimePeriod.SEVEN_DAYS],
157+
};
158+
141159
const TIME_WINDOW_TO_SESSION_INTERVAL = {
142160
[TimeWindow.THIRTY_MINUTES]: '30m',
143161
[TimeWindow.ONE_HOUR]: '1h',
@@ -246,6 +264,10 @@ class TriggersChart extends PureComponent<Props, State> {
246264
};
247265
}
248266

267+
if (this.props.dataset === Dataset.EVENTS_ANALYTICS_PLATFORM) {
268+
return EAP_AVAILABLE_TIME_PERIODS;
269+
}
270+
249271
return AVAILABLE_TIME_PERIODS;
250272
}
251273

0 commit comments

Comments
 (0)