feat(notifications-v2): Read from notification settings for weekly reports (#56621)

Read from the new notifications tables for weekly reports instead of
user options.

Author: snigdhas

src/sentry/notifications/notificationcontroller.py

@@ -553,3 +553,27 @@ def get_notification_provider_value_for_recipient_and_type(
             return value
 
         return NotificationSettingsOptionEnum.NEVER
+
+    def get_users_for_weekly_reports(self) -> list[int]:
+        if not self.organization_id:
+            raise Exception("Must specify organization_id")
+
+        if self.type != NotificationSettingEnum.REPORTS:
+            raise Exception(f"Type mismatch: the controller was initialized with type: {self.type}")
+
+        enabled_settings = self.get_all_enabled_settings(type=NotificationSettingEnum.REPORTS.value)
+        users = []
+        for recipient, setting in enabled_settings.items():
+            if not recipient_is_user(recipient):
+                continue
+
+            for type_map in setting.values():
+                provider_map = type_map[NotificationSettingEnum.REPORTS]
+                if (
+                    ExternalProviderEnum.EMAIL in provider_map
+                    and provider_map[ExternalProviderEnum.EMAIL]
+                    == NotificationSettingsOptionEnum.ALWAYS
+                ):
+                    users.append(recipient.id)
+
+        return users

src/sentry/tasks/weekly_reports.py

@@ -33,6 +33,10 @@
     OrganizationMember,
     OrganizationStatus,
 )
+from sentry.notifications.helpers import should_use_notifications_v2
+from sentry.notifications.notificationcontroller import NotificationController
+from sentry.notifications.types import NotificationSettingEnum
+from sentry.services.hybrid_cloud.user.model import RpcUser
 from sentry.services.hybrid_cloud.user_option import user_option_service
 from sentry.silo import SiloMode
 from sentry.snuba.dataset import Dataset
@@ -225,10 +229,16 @@ def prepare_organization_report(
         )
         return
 
+    use_notifications_v2 = should_use_notifications_v2(ctx.organization)
+
     # Finally, deliver the reports
     with sentry_sdk.start_span(op="weekly_reports.deliver_reports"):
         deliver_reports(
-            ctx, dry_run=dry_run, target_user=target_user, email_override=email_override
+            ctx,
+            dry_run=dry_run,
+            target_user=target_user,
+            email_override=email_override,
+            use_notifications_v2=use_notifications_v2,
         )
 
 
@@ -637,10 +647,33 @@ def fetch_key_performance_issue_groups(ctx):
 # For all users in the organization, we generate the template context for the user, and send the email.
 
 
-def deliver_reports(ctx, dry_run=False, target_user=None, email_override=None):
+def deliver_reports(
+    ctx, dry_run=False, target_user=None, email_override=None, use_notifications_v2=False
+):
     # Specify a sentry user to send this email.
     if email_override:
         send_email(ctx, target_user, dry_run=dry_run, email_override=email_override)
+    elif use_notifications_v2:
+        user_list = list(
+            OrganizationMember.objects.filter(
+                user_is_active=True,
+                organization_id=ctx.organization.id,
+            )
+            .filter(flags=F("flags").bitand(~OrganizationMember.flags["member-limit:restricted"]))
+            .values_list("user_id", flat=True)
+        )
+
+        users = [RpcUser(id=user_id) for user_id in user_list]
+        controller = NotificationController(
+            recipients=users,
+            organization_id=ctx.organization.id,
+            type=NotificationSettingEnum.REPORTS,
+        )
+
+        user_ids = controller.get_users_for_weekly_reports()
+        for user_id in user_ids:
+            send_email(ctx, user_id, dry_run=dry_run)
+
     else:
         # We save the subscription status of the user in a field in UserOptions.
         user_list = list(

tests/sentry/notifications/test_notificationcontroller.py

@@ -752,3 +752,26 @@ def test_get_notification_provider_value_for_recipient_and_type_with_layering(se
             )
             == NotificationSettingsOptionEnum.NEVER
         )
+
+    def test_get_users_for_weekly_reports(self):
+        controller = NotificationController(
+            recipients=[self.user],
+            organization_id=self.organization.id,
+            type=NotificationSettingEnum.REPORTS,
+        )
+        assert controller.get_users_for_weekly_reports() == [self.user.id]
+
+        add_notification_setting_option(
+            scope_type=NotificationScopeEnum.USER,
+            scope_identifier=self.user.id,
+            type=NotificationSettingEnum.REPORTS,
+            value=NotificationSettingsOptionEnum.NEVER,
+            user_id=self.user.id,
+        )
+
+        controller = NotificationController(
+            recipients=[self.user],
+            organization_id=self.organization.id,
+            type=NotificationSettingEnum.REPORTS,
+        )
+        assert controller.get_users_for_weekly_reports() == []