Skip to content

Commit e396e43

Browse files
committed
add guard when table metadata is un-available
1 parent 8a1a4cb commit e396e43

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/sentry/static/sentry/app/views/eventsV2/table/tableView.tsx

+6-4
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class TableView extends React.Component<TableViewProps> {
8585
_updateColumn = (columnIndex: number, nextColumn: TableColumn<keyof TableDataRow>) => {
8686
const {location, eventView, tableData} = this.props;
8787

88-
if (!tableData) {
88+
if (!tableData || !tableData.meta) {
8989
return;
9090
}
9191

@@ -112,7 +112,7 @@ class TableView extends React.Component<TableViewProps> {
112112
_deleteColumn = (columnIndex: number) => {
113113
const {location, eventView, tableData} = this.props;
114114

115-
if (!tableData) {
115+
if (!tableData || !tableData.meta) {
116116
return;
117117
}
118118

@@ -143,7 +143,7 @@ class TableView extends React.Component<TableViewProps> {
143143
_renderGridHeaderCell = (column: TableColumn<keyof TableDataRow>): React.ReactNode => {
144144
const {eventView, location, tableData} = this.props;
145145

146-
if (!tableData) {
146+
if (!tableData || !tableData.meta) {
147147
return column.name;
148148
}
149149

@@ -178,9 +178,11 @@ class TableView extends React.Component<TableViewProps> {
178178
dataRow: TableDataRow
179179
): React.ReactNode => {
180180
const {location, organization, tableData, eventView} = this.props;
181-
if (!tableData) {
181+
182+
if (!tableData || !tableData.meta) {
182183
return dataRow[column.key];
183184
}
185+
184186
const hasLinkField = eventView.hasAutolinkField();
185187
const forceLink =
186188
!hasLinkField && eventView.getFields().indexOf(String(column.field)) === 0;

src/sentry/static/sentry/app/views/eventsV2/table/types.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ export type TableDataRow = {
3131
};
3232

3333
export type TableData = {
34-
meta: MetaType;
34+
meta?: MetaType;
3535
data: Array<TableDataRow>;
3636
};

0 commit comments

Comments
 (0)