Skip to content

Commit f581c47

Browse files
ref(replays): move search bar below widgets (#54479)
Relates to getsentry/team-replay#140 <img width="1102" alt="SCR-20230809-lsth" src="https://github.com/getsentry/sentry/assets/56095982/152be84e-891a-4420-8e34-f838949d6dfe">
1 parent 6e6e69e commit f581c47

File tree

2 files changed

+18
-20
lines changed

2 files changed

+18
-20
lines changed

static/app/views/replays/list.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {t} from 'sentry/locale';
88
import {space} from 'sentry/styles/space';
99
import useReplayPageview from 'sentry/utils/replays/hooks/useReplayPageview';
1010
import useOrganization from 'sentry/utils/useOrganization';
11-
import ReplaysFilters from 'sentry/views/replays/list/filters';
11+
import {ReplaysFilters, ReplaysSearch} from 'sentry/views/replays/list/filters';
1212
import ReplaysErroneousDeadRageCards from 'sentry/views/replays/list/replaysErroneousDeadRageCards';
1313
import ReplaysList from 'sentry/views/replays/list/replaysList';
1414

@@ -34,9 +34,10 @@ function ReplaysListContainer() {
3434
<PageFiltersContainer>
3535
<Layout.Body>
3636
<Layout.Main fullWidth>
37-
<ReplaysFilters />
3837
<LayoutGap>
38+
<ReplaysFilters />
3939
<ReplaysErroneousDeadRageCards />
40+
<ReplaysSearch />
4041
<ReplaysList />
4142
</LayoutGap>
4243
</Layout.Main>

static/app/views/replays/list/filters.tsx

+15-18
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,31 @@ import DatePageFilter from 'sentry/components/datePageFilter';
55
import EnvironmentPageFilter from 'sentry/components/environmentPageFilter';
66
import PageFilterBar from 'sentry/components/organizations/pageFilterBar';
77
import ProjectPageFilter from 'sentry/components/projectPageFilter';
8-
import {space} from 'sentry/styles/space';
98
import {decodeScalar} from 'sentry/utils/queryString';
109
import {useLocation} from 'sentry/utils/useLocation';
1110
import useOrganization from 'sentry/utils/useOrganization';
1211
import usePageFilters from 'sentry/utils/usePageFilters';
1312
import ReplaySearchBar from 'sentry/views/replays/list/replaySearchBar';
1413

15-
function ReplaysFilters() {
16-
const {selection} = usePageFilters();
17-
const {pathname, query} = useLocation();
18-
const organization = useOrganization();
19-
14+
export function ReplaysFilters() {
2015
return (
21-
<FilterContainer>
16+
<Container>
2217
<PageFilterBar condensed>
2318
<ProjectPageFilter resetParamsOnChange={['cursor']} />
2419
<EnvironmentPageFilter resetParamsOnChange={['cursor']} />
2520
<DatePageFilter alignDropdown="left" resetParamsOnChange={['cursor']} />
2621
</PageFilterBar>
22+
</Container>
23+
);
24+
}
25+
26+
export function ReplaysSearch() {
27+
const {selection} = usePageFilters();
28+
const {pathname, query} = useLocation();
29+
const organization = useOrganization();
30+
31+
return (
32+
<Container>
2733
<ReplaySearchBar
2834
organization={organization}
2935
pageFilters={selection}
@@ -40,20 +46,11 @@ function ReplaysFilters() {
4046
});
4147
}}
4248
/>
43-
</FilterContainer>
49+
</Container>
4450
);
4551
}
4652

47-
const FilterContainer = styled('div')`
53+
const Container = styled('div')`
4854
display: inline-grid;
49-
grid-template-columns: minmax(0, max-content) minmax(20rem, 1fr);
50-
gap: ${space(2)};
5155
width: 100%;
52-
margin-bottom: ${space(2)};
53-
54-
@media (max-width: ${p => p.theme.breakpoints.large}) {
55-
grid-template-columns: minmax(0, 1fr);
56-
}
5756
`;
58-
59-
export default ReplaysFilters;

0 commit comments

Comments
 (0)