Skip to content

Commit f7de14b

Browse files
fix(ui): Consistent PanelHeader button sizing (#55164)
Fixes various places where buttons are too big for headers
1 parent b5cd18b commit f7de14b

File tree

6 files changed

+8
-13
lines changed

6 files changed

+8
-13
lines changed

static/app/components/pluginConfig.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ class PluginConfig extends Component<Props, State> {
132132
</Button>
133133
)}
134134
<Button
135-
size="sm"
135+
size="xs"
136136
onClick={this.handleDisablePlugin}
137137
disabled={!hasWriteAccess}
138138
>

static/app/views/settings/components/teamSelect/teamSelectForMember.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ function TeamSelect({
111111

112112
return (
113113
<Panel>
114-
<TeamPanelHeader>
114+
<TeamPanelHeader hasButtons>
115115
<div>{t('Team')}</div>
116116
<div />
117117
<div>

static/app/views/settings/components/teamSelect/utils.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,7 @@ export function DropdownAddTeam({
100100
alignMenu="right"
101101
>
102102
{({isOpen}) => (
103-
<DropdownButton
104-
aria-label={t('Add Team')}
105-
isOpen={isOpen}
106-
size="xs"
107-
disabled={disabled}
108-
>
103+
<DropdownButton isOpen={isOpen} size="xs" disabled={disabled}>
109104
{t('Add Team')}
110105
</DropdownButton>
111106
)}

static/app/views/settings/project/loaderScript.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ function LoaderItem({
115115
{tct('Client Key: [name]', {name: projectKey.name})}
116116

117117
<LinkButton
118+
size="xs"
118119
to={`/settings/${organization.slug}/projects/${project.slug}/keys/${projectKey.id}/`}
119120
>
120121
{t('View Key Details')}

static/app/views/settings/project/projectKeys/list/keyRow.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function KeyRow({
5858
)}
5959
</Title>
6060
<Controls>
61-
<Button to={editUrl} size="sm">
61+
<Button to={editUrl} size="xs">
6262
{t('Configure')}
6363
</Button>
6464
<Confirm
@@ -71,7 +71,7 @@ function KeyRow({
7171
: t('Are you sure you want to enable this key?')
7272
}
7373
>
74-
<Button size="sm">{data.isActive ? t('Disable') : t('Enable')}</Button>
74+
<Button size="xs">{data.isActive ? t('Disable') : t('Enable')}</Button>
7575
</Confirm>
7676
<Confirm
7777
disabled={!hasWriteAccess}
@@ -82,7 +82,7 @@ function KeyRow({
8282
'Are you sure you want to remove this key? This action is irreversible.'
8383
)}
8484
>
85-
<Button size="sm" icon={<IconDelete />} aria-label={t('Delete')} />
85+
<Button size="xs" icon={<IconDelete size="xs" />} aria-label={t('Delete')} />
8686
</Confirm>
8787
</Controls>
8888
</PanelHeader>

static/app/views/settings/projectDebugFiles/sources/customRepositories/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,7 @@ function CustomRepositories({
235235
<DropdownButton
236236
isOpen={isOpen}
237237
disabled={addRepositoryButtonDisabled}
238-
size="sm"
239-
aria-label={t('Add Repository')}
238+
size="xs"
240239
>
241240
{t('Add Repository')}
242241
</DropdownButton>

0 commit comments

Comments
 (0)