From 7cdddc986122d3e612af0bdc24fab640ef7718dd Mon Sep 17 00:00:00 2001
From: Billy Vong <billy@sentry.io>
Date: Thu, 23 Apr 2020 09:22:39 -0700
Subject: [PATCH] ref(css): Remove CSS class `event-issue-header`

This is unused (there are no h3s nested under `<EventOrGroupHeader>` component. Change class name to `data-test-id` for acceptance tests.
---
 .../app/components/eventOrGroupHeader.jsx     |  4 +---
 src/sentry/static/sentry/less/stream.less     | 24 -------------------
 tests/acceptance/page_objects/issue_list.py   |  2 +-
 .../test_organization_group_index.py          |  2 +-
 .../groupMergedView.spec.jsx.snap             |  4 ++--
 .../__snapshots__/groupSimilar.spec.jsx.snap  |  2 +-
 6 files changed, 6 insertions(+), 32 deletions(-)

diff --git a/src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx b/src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx
index 4cf4ba6694b946..5bac5c21d5c26e 100644
--- a/src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx
+++ b/src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx
@@ -3,7 +3,6 @@ import React from 'react';
 import {withRouter} from 'react-router';
 import styled from '@emotion/styled';
 import {css} from '@emotion/core';
-import classNames from 'classnames';
 import capitalize from 'lodash/capitalize';
 
 import SentryTypes from 'app/sentryTypes';
@@ -88,12 +87,11 @@ class EventOrGroupHeader extends React.Component {
 
   render() {
     const {className, size, data} = this.props;
-    const cx = classNames('event-issue-header', className);
     const location = getLocation(data);
     const message = getMessage(data);
 
     return (
-      <div className={cx}>
+      <div className={className} data-test-id="event-issue-header">
         <Title size={size}>{this.getTitle()}</Title>
         {location && <Location size={size}>{location}</Location>}
         {message && <Message size={size}>{message}</Message>}
diff --git a/src/sentry/static/sentry/less/stream.less b/src/sentry/static/sentry/less/stream.less
index aabd1255b6d5c9..4466306b351075 100644
--- a/src/sentry/static/sentry/less/stream.less
+++ b/src/sentry/static/sentry/less/stream.less
@@ -936,27 +936,3 @@
     }
   }
 }
-
-.event-issue-header {
-  h3 {
-    font-size: 16px;
-    line-height: 1.1;
-    margin: 0 0 5px;
-    font-weight: 600;
-
-    em {
-      font-style: normal;
-      font-size: 14px;
-      color: @60;
-      font-weight: normal;
-    }
-
-    a {
-      color: @gray-darker;
-
-      &:hover {
-        color: @gray-darkest;
-      }
-    }
-  }
-}
diff --git a/tests/acceptance/page_objects/issue_list.py b/tests/acceptance/page_objects/issue_list.py
index b014c80bf55be5..066cf6da4c4bae 100644
--- a/tests/acceptance/page_objects/issue_list.py
+++ b/tests/acceptance/page_objects/issue_list.py
@@ -14,7 +14,7 @@ def visit_issue_list(self, org, query=""):
         self.wait_until_loaded()
 
     def wait_for_stream(self):
-        self.browser.wait_until(".event-issue-header", timeout=20)
+        self.browser.wait_until('[data-test-id="event-issue-header"]', timeout=20)
 
     def select_issue(self, position):
         self.browser.click(u'[data-test-id="group"]:nth-child({})'.format(position))
diff --git a/tests/acceptance/test_organization_group_index.py b/tests/acceptance/test_organization_group_index.py
index 92892e98b7a74a..01730514c5c358 100644
--- a/tests/acceptance/test_organization_group_index.py
+++ b/tests/acceptance/test_organization_group_index.py
@@ -70,7 +70,7 @@ def test_with_results(self, mock_now):
         self.page.wait_for_stream()
         self.browser.snapshot("organization issues with issues")
 
-        groups = self.browser.find_elements_by_class_name("event-issue-header")
+        groups = self.browser.find_elements_by_css_selector('[data-test-id="event-issue-header"]')
         assert len(groups) == 2
         assert "oh snap" in groups[0].text
         assert "oh no" in groups[1].text
diff --git a/tests/js/spec/views/organizationGroupDetails/__snapshots__/groupMergedView.spec.jsx.snap b/tests/js/spec/views/organizationGroupDetails/__snapshots__/groupMergedView.spec.jsx.snap
index cf80201c0c81b3..fdfab195532976 100644
--- a/tests/js/spec/views/organizationGroupDetails/__snapshots__/groupMergedView.spec.jsx.snap
+++ b/tests/js/spec/views/organizationGroupDetails/__snapshots__/groupMergedView.spec.jsx.snap
@@ -987,7 +987,7 @@ exports[`Issues -> Merged View renders with mocked data 1`] = `
                                   size="normal"
                                 >
                                   <div
-                                    className="event-issue-header"
+                                    data-test-id="event-issue-header"
                                   >
                                     <Title
                                       size="normal"
@@ -1736,7 +1736,7 @@ exports[`Issues -> Merged View renders with mocked data 1`] = `
                                   size="normal"
                                 >
                                   <div
-                                    className="event-issue-header"
+                                    data-test-id="event-issue-header"
                                   >
                                     <Title
                                       size="normal"
diff --git a/tests/js/spec/views/organizationGroupDetails/__snapshots__/groupSimilar.spec.jsx.snap b/tests/js/spec/views/organizationGroupDetails/__snapshots__/groupSimilar.spec.jsx.snap
index 7d165dabeed2d4..8b8a722ed7fc22 100644
--- a/tests/js/spec/views/organizationGroupDetails/__snapshots__/groupSimilar.spec.jsx.snap
+++ b/tests/js/spec/views/organizationGroupDetails/__snapshots__/groupSimilar.spec.jsx.snap
@@ -835,7 +835,7 @@ exports[`Issues Similar View renders with mocked data 1`] = `
                               size="normal"
                             >
                               <div
-                                className="event-issue-header"
+                                data-test-id="event-issue-header"
                               >
                                 <Title
                                   size="normal"