From 6cfd82f366fdd6da5909bde4137e3f78a3c69b80 Mon Sep 17 00:00:00 2001 From: Dominik Buszowiecki Date: Fri, 14 Mar 2025 17:12:55 -0400 Subject: [PATCH] fix --- src/sentry/search/eap/spans/aggregates.py | 2 ++ .../api/endpoints/test_organization_events_span_indexed.py | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/sentry/search/eap/spans/aggregates.py b/src/sentry/search/eap/spans/aggregates.py index 7cf4a150ae0702..6729aa3e8d9b4a 100644 --- a/src/sentry/search/eap/spans/aggregates.py +++ b/src/sentry/search/eap/spans/aggregates.py @@ -68,6 +68,8 @@ def resolve_key_eq_value_filter(args: ResolvedArguments) -> tuple[AttributeKey, def resolve_count_scores(args: ResolvedArguments) -> tuple[AttributeKey, TraceItemFilter]: score_column = cast(str, args[0]) ratio_column_name = score_column.replace("measurements.score", "score.ratio") + if ratio_column_name == "score.ratio.total": + ratio_column_name = "score.total" attribute_key = AttributeKey(name=ratio_column_name, type=AttributeKey.TYPE_DOUBLE) filter = TraceItemFilter(exists_filter=ExistsFilter(key=attribute_key)) diff --git a/tests/snuba/api/endpoints/test_organization_events_span_indexed.py b/tests/snuba/api/endpoints/test_organization_events_span_indexed.py index 6cf1e687113827..9d0126e4c967ba 100644 --- a/tests/snuba/api/endpoints/test_organization_events_span_indexed.py +++ b/tests/snuba/api/endpoints/test_organization_events_span_indexed.py @@ -2985,7 +2985,7 @@ def test_count_scores(self): { "measurements": { "score.ratio.lcp": {"value": 0.03}, - "score.ratio.total": {"value": 0.43}, + "score.total": {"value": 0.43}, } }, start_ts=self.ten_mins_ago, @@ -2993,7 +2993,7 @@ def test_count_scores(self): self.create_span( { "measurements": { - "score.ratio.total": {"value": 1.0}, + "score.total": {"value": 1.0}, } }, start_ts=self.ten_mins_ago, @@ -3001,7 +3001,7 @@ def test_count_scores(self): self.create_span( { "measurements": { - "score.ratio.total": {"value": 0.0}, + "score.total": {"value": 0.0}, } }, start_ts=self.ten_mins_ago,