Skip to content

Commit 79ed8a4

Browse files
committed
Clippy & fmt.
1 parent 902bb3d commit 79ed8a4

File tree

6 files changed

+29
-25
lines changed

6 files changed

+29
-25
lines changed

tests/tests/wgpu-gpu/ray_tracing/as_build.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@ fn out_of_order_as_build_use(ctx: TestingContext) {
235235
None,
236236
);
237237

238-
239238
let as_ctx = AsBuildContext::new(
240239
&ctx,
241240
AccelerationStructureFlags::empty(),

wgpu-core/src/command/compute.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ use crate::{
2424
global::Global,
2525
hal_label, id,
2626
init_tracker::{BufferInitTrackerAction, MemoryInitKind},
27-
pipeline::ComputePipeline
28-
,
27+
pipeline::ComputePipeline,
2928
resource::{
3029
self, Buffer, DestroyedResourceError, InvalidResourceError, Labeled,
3130
MissingBufferUsageError, ParentDevice,

wgpu-core/src/command/ray_tracing.rs

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ use core::{
77

88
use wgt::{math::align_to, BufferUsages, BufferUses, Features};
99

10+
use crate::device::resource::CommandIndices;
11+
use crate::lock::RwLockWriteGuard;
12+
use crate::ray_tracing::{AsAction, AsBuild, TlasBuild, ValidateAsActionsError};
1013
use crate::{
1114
command::CommandBufferMutable,
1215
device::queue::TempResource,
@@ -15,19 +18,15 @@ use crate::{
1518
id::CommandEncoderId,
1619
init_tracker::MemoryInitKind,
1720
ray_tracing::{
18-
BlasBuildEntry, BlasGeometries, BlasTriangleGeometry,
19-
BuildAccelerationStructureError, TlasBuildEntry, TlasInstance, TlasPackage,
20-
TraceBlasBuildEntry, TraceBlasGeometries, TraceBlasTriangleGeometry, TraceTlasInstance,
21-
TraceTlasPackage,
21+
BlasBuildEntry, BlasGeometries, BlasTriangleGeometry, BuildAccelerationStructureError,
22+
TlasBuildEntry, TlasInstance, TlasPackage, TraceBlasBuildEntry, TraceBlasGeometries,
23+
TraceBlasTriangleGeometry, TraceTlasInstance, TraceTlasPackage,
2224
},
2325
resource::{AccelerationStructure, Blas, Buffer, Labeled, StagingBuffer, Tlas},
2426
scratch::ScratchBuffer,
2527
snatch::SnatchGuard,
2628
track::PendingTransition,
2729
};
28-
use crate::device::resource::CommandIndices;
29-
use crate::lock::RwLockWriteGuard;
30-
use crate::ray_tracing::{AsAction, AsBuild, TlasBuild, ValidateAsActionsError};
3130

3231
struct TriangleBufferStore<'a> {
3332
vertex_buffer: Arc<Buffer>,
@@ -744,9 +743,9 @@ impl CommandBufferMutable {
744743
match action {
745744
AsAction::Build(build) => {
746745
let build_command_index = NonZeroU64::new(
747-
command_index_guard.next_acceleration_structure_build_command_index
746+
command_index_guard.next_acceleration_structure_build_command_index,
748747
)
749-
.unwrap();
748+
.unwrap();
750749

751750
command_index_guard.next_acceleration_structure_build_command_index += 1;
752751
for blas in build.blas_s_built.iter() {
@@ -763,17 +762,19 @@ impl CommandBufferMutable {
763762
}
764763
}
765764
*tlas_build.tlas.built_index.write() = Some(build_command_index);
766-
tlas_build.tlas.dependencies.write().clone_from(&tlas_build.dependencies)
765+
tlas_build
766+
.tlas
767+
.dependencies
768+
.write()
769+
.clone_from(&tlas_build.dependencies)
767770
}
768771
}
769772
AsAction::UseTlas(tlas) => {
770773
let tlas_build_index = tlas.built_index.read();
771774
let dependencies = tlas.dependencies.read();
772775

773776
if (*tlas_build_index).is_none() {
774-
return Err(ValidateAsActionsError::UsedUnbuiltTlas(
775-
tlas.error_ident(),
776-
));
777+
return Err(ValidateAsActionsError::UsedUnbuiltTlas(tlas.error_ident()));
777778
}
778779
for blas in dependencies.deref() {
779780
let blas_build_index = *blas.built_index.read();

wgpu-core/src/device/queue.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ use smallvec::SmallVec;
1010
use thiserror::Error;
1111

1212
use super::{life::LifetimeTracker, Device};
13+
use crate::device::resource::CommandIndices;
1314
#[cfg(feature = "trace")]
1415
use crate::device::trace::Action;
1516
use crate::scratch::ScratchBuffer;
@@ -37,7 +38,6 @@ use crate::{
3738
track::{self, Tracker, TrackerIndex},
3839
FastHashMap, SubmissionIndex,
3940
};
40-
use crate::device::resource::CommandIndices;
4141

4242
pub struct Queue {
4343
raw: Box<dyn hal::DynQueue>,
@@ -1553,7 +1553,9 @@ fn validate_command_buffer(
15531553
}
15541554
}
15551555

1556-
if let Err(e) = cmd_buf_data.validate_acceleration_structure_actions(snatch_guard, command_index_guard) {
1556+
if let Err(e) =
1557+
cmd_buf_data.validate_acceleration_structure_actions(snatch_guard, command_index_guard)
1558+
{
15571559
return Err(e.into());
15581560
}
15591561
}

wgpu-core/src/device/resource.rs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ pub struct Device {
9595
/// so waiting for this value won't hang waiting for work that was never
9696
/// submitted.
9797
///
98-
/// [`active_submission_index`]: Device::active_submission_index
98+
/// [`active_submission_index`]: CommandIndices::active_submission_index
9999
pub(crate) last_successful_submission_index: hal::AtomicFenceValue,
100100

101101
// NOTE: if both are needed, the `snatchable_lock` must be consistently acquired before the
@@ -273,11 +273,14 @@ impl Device {
273273
zero_buffer: ManuallyDrop::new(zero_buffer),
274274
label: desc.label.to_string(),
275275
command_allocator,
276-
command_indices: RwLock::new(rank::DEVICE_COMMAND_INDICES, CommandIndices {
277-
active_submission_index: 0,
278-
// By starting at one, we can put the result in a NonZeroU64.
279-
next_acceleration_structure_build_command_index: 1,
280-
}),
276+
command_indices: RwLock::new(
277+
rank::DEVICE_COMMAND_INDICES,
278+
CommandIndices {
279+
active_submission_index: 0,
280+
// By starting at one, we can put the result in a NonZeroU64.
281+
next_acceleration_structure_build_command_index: 1,
282+
},
283+
),
281284
last_successful_submission_index: AtomicU64::new(0),
282285
fence: RwLock::new(rank::DEVICE_FENCE, ManuallyDrop::new(fence)),
283286
snatchable_lock: unsafe { SnatchLock::new(rank::DEVICE_SNATCHABLE_LOCK) },

wgpu-core/src/ray_tracing.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ pub(crate) struct AsBuild {
208208
#[derive(Debug, Clone)]
209209
pub(crate) enum AsAction {
210210
Build(AsBuild),
211-
UseTlas(Arc<Tlas>)
211+
UseTlas(Arc<Tlas>),
212212
}
213213

214214
#[derive(Debug, Clone)]

0 commit comments

Comments
 (0)