-
Notifications
You must be signed in to change notification settings - Fork 1k
Naga: Should not be a structural type system #5796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
area: validation
Issues related to validation, diagnostics, and error handling
naga
Shader Translator
type: bug
Something isn't working
Comments
Thanks for filing! I thought we had an issue tracking this but I can't seem to find it. |
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this issue
Mar 28, 2025
6 tasks
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this issue
Mar 28, 2025
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this issue
Apr 10, 2025
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this issue
Apr 10, 2025
Vecvec
pushed a commit
to Vecvec/wgpu
that referenced
this issue
Apr 10, 2025
Vecvec
pushed a commit
to Vecvec/wgpu
that referenced
this issue
Apr 11, 2025
jimblandy
pushed a commit
to jimblandy/wgpu
that referenced
this issue
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: validation
Issues related to validation, diagnostics, and error handling
naga
Shader Translator
type: bug
Something isn't working
Description
Currently naga will accept using a struct as another struct with the same layout.
Could it be that type checking only checks if the layout of a type is the same? And that aliases could be an issue, because they're represented as a copy of a given type in the naga::Module.
Repro steps
Add the following to
naga/tests/wgsl_errors.rs
. Naga creates a module and says it's valid, instead of throwing the expected error.Expected vs observed behavior
I expected it to match the Chrome behaviour of throwing an error.
Platform
The text was updated successfully, but these errors were encountered: