Skip to content

Commit 38280a6

Browse files
committed
address review comments
1 parent 670f849 commit 38280a6

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

examples/llama-bench/llama-bench.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,7 @@ static cmd_params parse_cmd_params(int argc, char ** argv) {
392392
invalid_param = true;
393393
break;
394394
}
395-
auto p = split<std::string>(argv[i], split_delim);
396-
params.rpc_servers.insert(params.rpc_servers.end(), p.begin(), p.end());
395+
params.rpc_servers.push_back(argv[i]);
397396
} else if (arg == "-sm" || arg == "--split-mode") {
398397
if (++i >= argc) {
399398
invalid_param = true;
@@ -608,6 +607,7 @@ static std::vector<cmd_params_instance> get_cmd_params_instances(const cmd_param
608607
// this ordering minimizes the number of times that each model needs to be reloaded
609608
for (const auto & m : params.model)
610609
for (const auto & nl : params.n_gpu_layers)
610+
for (const auto & rpc : params.rpc_servers)
611611
for (const auto & sm : params.split_mode)
612612
for (const auto & mg : params.main_gpu)
613613
for (const auto & ts : params.tensor_split)
@@ -634,7 +634,7 @@ static std::vector<cmd_params_instance> get_cmd_params_instances(const cmd_param
634634
/* .type_v = */ tv,
635635
/* .n_threads = */ nt,
636636
/* .n_gpu_layers = */ nl,
637-
/* .rpc_servers = */ join(params.rpc_servers, ","),
637+
/* .rpc_servers = */ rpc,
638638
/* .split_mode = */ sm,
639639
/* .main_gpu = */ mg,
640640
/* .no_kv_offload= */ nkvo,
@@ -660,7 +660,7 @@ static std::vector<cmd_params_instance> get_cmd_params_instances(const cmd_param
660660
/* .type_v = */ tv,
661661
/* .n_threads = */ nt,
662662
/* .n_gpu_layers = */ nl,
663-
/* .rpc_servers = */ join(params.rpc_servers, ","),
663+
/* .rpc_servers = */ rpc,
664664
/* .split_mode = */ sm,
665665
/* .main_gpu = */ mg,
666666
/* .no_kv_offload= */ nkvo,
@@ -686,7 +686,7 @@ static std::vector<cmd_params_instance> get_cmd_params_instances(const cmd_param
686686
/* .type_v = */ tv,
687687
/* .n_threads = */ nt,
688688
/* .n_gpu_layers = */ nl,
689-
/* .rpc_servers = */ join(params.rpc_servers, ","),
689+
/* .rpc_servers = */ rpc,
690690
/* .split_mode = */ sm,
691691
/* .main_gpu = */ mg,
692692
/* .no_kv_offload= */ nkvo,

0 commit comments

Comments
 (0)