Skip to content

Commit 578754b

Browse files
authored
sycl: Support sycl_ext_oneapi_limited_graph (#12873)
The current usage of the SYCL-Graph extension checks for the `sycl_ext_oneapi_graph` device aspect. However, it is also possible to support `sycl_ext_oneapi_limied_graph` devices that don't support update
1 parent b2034c2 commit 578754b

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

ggml/src/ggml-sycl/ggml-sycl.cpp

+6-3
Original file line numberDiff line numberDiff line change
@@ -3653,7 +3653,8 @@ static ggml_status ggml_backend_sycl_graph_compute(ggml_backend_t backend, ggml_
36533653

36543654
#ifdef GGML_SYCL_GRAPH
36553655
if (!g_ggml_sycl_disable_graph) {
3656-
if (!sycl_ctx->exec_graph && !dpct::get_device(sycl_ctx->device).has(sycl::aspect::ext_oneapi_graph)) {
3656+
const bool graph_support = dpct::get_device(sycl_ctx->device).has(sycl::aspect::ext_oneapi_limited_graph);
3657+
if (!graph_support) {
36573658
GGML_SYCL_DEBUG("[SYCL-GRAPH] can not use graphs on device:%d\n", sycl_ctx->device);
36583659
ggml_backend_sycl_graph_compute_impl(sycl_ctx, cgraph);
36593660
return GGML_STATUS_SUCCESS;
@@ -3664,8 +3665,10 @@ static ggml_status ggml_backend_sycl_graph_compute(ggml_backend_t backend, ggml_
36643665
ggml_backend_sycl_graph_compute_impl(sycl_ctx, cgraph);
36653666
model_sycl_graph.end_recording();
36663667

3667-
if (!sycl_ctx->exec_graph) {
3668-
auto exec_graph = model_sycl_graph.finalize({sycl_ex::property::graph::updatable{}});
3668+
const bool graph_update_support = dpct::get_device(sycl_ctx->device).has(sycl::aspect::ext_oneapi_graph);
3669+
if (!sycl_ctx->exec_graph || !graph_update_support) {
3670+
auto exec_graph = graph_update_support ? model_sycl_graph.finalize(sycl_ex::property::graph::updatable{}) :
3671+
model_sycl_graph.finalize();
36693672
sycl_ctx->exec_graph = std::make_unique<
36703673
sycl_ex::command_graph<sycl_ex::graph_state::executable>>(exec_graph);
36713674
} else {

0 commit comments

Comments
 (0)