Skip to content

Bug: Renaming of executables breaks tutorials #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gpacix opened this issue Jul 9, 2024 · 6 comments
Closed

Bug: Renaming of executables breaks tutorials #8397

gpacix opened this issue Jul 9, 2024 · 6 comments
Labels
bug-unconfirmed low severity Used to report low severity bugs in llama.cpp (e.g. cosmetic issues, non critical UI glitches) stale

Comments

@gpacix
Copy link

gpacix commented Jul 9, 2024

What happened?

I was getting started with llama.cpp and the existing tutorials all say to run ./main and./server, which have very recently (1c641e6, 2024-06-12) been renamed to ./llama-cli and ./llama-server (as I understand it).

Could you please (temporarily) restore the old names, and deprecate them instead— by adding shell scripts with the old names that announce the deprecation and run the new executable with the same arguments? Even just announcing the new name and quitting would be helpful.

While I eventually figured this out, it is a frustrating stumbling block for new users (and possibly existing ones, as well).

Name and Version

./llama-cli --version
version: 0 (unknown)
built with Apple clang version 13.0.0 (clang-1300.0.29.30) for x86_64-apple-darwin20.6.0

Note: I downloaded the source, version b3334, and built it myself.

What operating system are you seeing the problem on?

Mac

Relevant log output

$ ./main
bash: ./main: No such file or directory
$ ./server
bash: ./server: No such file or directory
@gpacix gpacix added bug-unconfirmed low severity Used to report low severity bugs in llama.cpp (e.g. cosmetic issues, non critical UI glitches) labels Jul 9, 2024
@gpacix
Copy link
Author

gpacix commented Jul 9, 2024

Yes, I understand that, that's fine.

All I am asking for is a reasonable, useful error message when someone tries to run ./main​, along the lines of:

"Error: ./main has been renamed to ./llama-cli; please update your scripts and documentation"

(and similarly for ./server).

@slaren
Copy link
Member

slaren commented Jul 9, 2024

For the most part this should have been addressed in #8283

@gpacix
Copy link
Author

gpacix commented Jul 9, 2024

A project that fixes problems by the time I can even report them? Nice! Thanks!

@HanClinto
Copy link
Collaborator

For the most part this should have been addressed in #8283

One change we made in #8283 was to make it so that it only builds the replacement main binary (that gives the name-change warning message) if it sees an existing main binary in the same folder.

(base) ➜  llama.cpp git:(legacy-binaries) ✗ ./main

WARNING: The binary 'main' is deprecated.
 Please use 'llama-cli' instead.
 See https://github.com/ggerganov/llama.cpp/tree/master/examples/deprecation-warning/README.md for more information.

However, because it doesn't always build the binaries, then this won't help for people who are following a tutorial and typing in main in a fresh install -- for that, we might want to remove the main binary filename check and ensure that at least that binary builds all the time (for now, until everything else gets upgraded). I think that would address the majority of what @gpacix is asking for?

@HanClinto
Copy link
Collaborator

All I am asking for is a reasonable, useful error message when someone tries to run ./main​, along the lines of:

"Error: ./main has been renamed to ./llama-cli; please update your scripts and documentation"

I just opened a PR (#8404) to build the name-migration-alert main binary every time make is run. Hopefully this will help some of your use-case, @gpacix?

(and similarly for ./server).

Are there tutorials that you've seen that instruct people to run server? If so, then I'll modify that PR to also build server every time as well.

@github-actions github-actions bot added the stale label Aug 10, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-unconfirmed low severity Used to report low severity bugs in llama.cpp (e.g. cosmetic issues, non critical UI glitches) stale
Projects
None yet
Development

No branches or pull requests

3 participants