Skip to content

Commit 06656e9

Browse files
alecgibsongiggio
authored andcommitted
Update default binary CDN URL
In the last couple of days, the CDN URL has changed from: ``` https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing ``` [Wayback Machine][1] to: ``` https://storage.googleapis.com/chrome-for-testing-public ``` [Current][2] This change updates the default to match the current URL [1]: https://web.archive.org/web/20240213030506/https://googlechromelabs.github.io/chrome-for-testing/#stable [2]: https://googlechromelabs.github.io/chrome-for-testing/#stable
1 parent fdce816 commit 06656e9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ how these urls work.
6969

7070
Npm config:
7171
For metadata use `chromedriver_cdnurl`. The default is `https://googlechromelabs.github.io`.
72-
For binaries use `chromedriver_cdnbinariesurl`. The default is `https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing`.
72+
For binaries use `chromedriver_cdnbinariesurl`. The default is `https://storage.googleapis.com/chrome-for-testing-public`.
7373

7474
```shell
7575
npm install chromedriver --chromedriver_cdnurl=https://npmmirror.com/metadata --chromedriver_cdnbinariesurl=https://npmmirror.com/binaries

install.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ if (skipDownload) {
6363
const chromedriverIsAvailable = await verifyIfChromedriverIsAvailableAndHasCorrectVersion(chromedriverVersion, chromedriverBinaryFilePath);
6464
if (!chromedriverIsAvailable) {
6565
console.log('Current existing ChromeDriver binary is unavailable, proceeding with download and extraction.');
66-
const cdnBinariesUrl = (process.env.npm_config_chromedriver_cdnbinariesurl || process.env.CHROMEDRIVER_CDNBINARIESURL || 'https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing').replace(/\/+$/, '');
66+
const cdnBinariesUrl = (process.env.npm_config_chromedriver_cdnbinariesurl || process.env.CHROMEDRIVER_CDNBINARIESURL || 'https://storage.googleapis.com/chrome-for-testing-public').replace(/\/+$/, '');
6767
downloadedFile = await downloadFile(useLegacyMethod ? legacyCdnUrl : cdnBinariesUrl, useLegacyMethod, downloadedFile, chromedriverVersion, platform);
6868
await extractDownload(extractDirectory, chromedriverBinaryFilePath, downloadedFile);
6969
}

0 commit comments

Comments
 (0)