Skip to content

Does not work with git worktree #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davireis opened this issue Jun 9, 2017 · 2 comments
Closed

Does not work with git worktree #285

davireis opened this issue Jun 9, 2017 · 2 comments
Labels

Comments

@davireis
Copy link

davireis commented Jun 9, 2017

Working directories created with https://git-scm.com/docs/git-worktree unfortunately use a .git file whose contents is the path of the real .git directory, and that breaks the check maven-git-commit-id does. The only workaround I found was to set failOnUnableToExtractRepoInfo. Ideally, maven-git-commit-id should use git itself to verify existence and query data in the .git dir.

@ktoso
Copy link
Collaborator

ktoso commented Jun 10, 2017

Thanks for the ticket, I'm not actively maintaining this repo so it would be best if you try to submit a PR. I'm happy to review / merge then etc,

@TheSnoozer TheSnoozer added the bug label Jun 30, 2017
@TheSnoozer
Copy link
Collaborator

Not to be picky but this is pretty much a duplicate of
#215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants