Skip to content

> It looks like we need to trim \r from the output of ssh-keygen -Y find-principals's on Windows, or we end up calling ssh-keygen -Y verify with a bogus signer identity, as per screenshot. [ssh-keygen.c:2841](https://github.com/openssh/openssh-portable/blob/master/ssh-keygen.c#L2841) seems to confirm this hypothesis. Signature verification passes with the fix. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukaszibi opened this issue Dec 5, 2021 · 0 comments
Labels

Comments

@lukaszibi
Copy link

It looks like we need to trim \r from the output of ssh-keygen -Y find-principals's on Windows, or we end up calling ssh-keygen -Y verify with a bogus signer identity, as per screenshot. ssh-keygen.c:2841 seems to confirm this hypothesis. Signature verification passes with the fix.

That looks like good material to put into the commit message.

As the DCO bot pointed out, you also need to add your Signed-off-by: trailer.

So: please amend the commit message with git commit -s, providing a thorough commit message, and then force-push.

Originally posted by @dscho in git-for-windows/git#3561 (comment)

@rimrul rimrul closed this as completed Dec 5, 2021
@rimrul rimrul added the invalid label Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants