Skip to content

Commit 05163e3

Browse files
max630dscho
authored andcommitted
mingw: use CreateHardLink directly
It was observed that the current implementation of of get_proc_addr() fails to load the kernel32.dll with code ERROR_INVALID_PARAMETER. Probably the reason is that kernel32.dll is already loaded. The behavior was seen at Windows SP1, both 32bit and 64bit. Probably it would behave same way in some or all other Windows versions. This breaks all usages of "clone --local", including the automatic tests where they call it. The function CreateHardLink is available in all supported Windows versions (since Windows XP), so there is no more need to resolve it in runtime. Signed-off-by: Max Kirillov <[email protected]>
1 parent a01cdb8 commit 05163e3

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

compat/mingw.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2666,13 +2666,8 @@ int mingw_raise(int sig)
26662666

26672667
int link(const char *oldpath, const char *newpath)
26682668
{
2669-
DECLARE_PROC_ADDR(kernel32.dll, BOOL, CreateHardLinkW,
2670-
LPCWSTR, LPCWSTR, LPSECURITY_ATTRIBUTES);
26712669
wchar_t woldpath[MAX_LONG_PATH], wnewpath[MAX_LONG_PATH];
26722670

2673-
if (!INIT_PROC_ADDR(CreateHardLinkW))
2674-
return -1;
2675-
26762671
if (xutftowcs_long_path(woldpath, oldpath) < 0 ||
26772672
xutftowcs_long_path(wnewpath, newpath) < 0)
26782673
return -1;

0 commit comments

Comments
 (0)