Skip to content

Commit 3bba4ab

Browse files
dschoGit for Windows Build Agent
authored and
Git for Windows Build Agent
committed
fixup??? mingw: work around rename() failing on a read-only file
The `mingw_unlink()` function is now abused for a platform abstraction layer. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 519bf8b commit 3bba4ab

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

compat/mingw.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2937,7 +2937,7 @@ int mingw_rename(const char *pold, const char *pnew)
29372937
if (gle == ERROR_ACCESS_DENIED) {
29382938
if (is_inside_windows_container()) {
29392939
/* Fall back to copy to destination & remove source */
2940-
if (CopyFileW(wpold, wpnew, FALSE) && !mingw_unlink(pold))
2940+
if (CopyFileW(wpold, wpnew, FALSE) && !mingw_unlink(pold, 1))
29412941
return 0;
29422942
gle = GetLastError();
29432943
} else if ((attrsold = GetFileAttributesW(wpold)) & FILE_ATTRIBUTE_READONLY) {

0 commit comments

Comments
 (0)