Skip to content

Commit 4dcd99b

Browse files
kbleesGit for Windows Build Agent
authored and
Git for Windows Build Agent
committed
Win32: implement basic symlink() functionality (file symlinks only)
Implement symlink() that always creates file symlinks. Fails with ENOSYS if symlinks are disabled or unsupported. Note: CreateSymbolicLinkW() was introduced with symlink support in Windows Vista. For compatibility with Windows XP, we need to load it dynamically and fail gracefully if it isnt's available. Signed-off-by: Karsten Blees <[email protected]>
1 parent 4a7f99f commit 4dcd99b

File tree

2 files changed

+29
-2
lines changed

2 files changed

+29
-2
lines changed

compat/mingw.c

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2568,6 +2568,34 @@ int link(const char *oldpath, const char *newpath)
25682568
return 0;
25692569
}
25702570

2571+
int symlink(const char *target, const char *link)
2572+
{
2573+
wchar_t wtarget[MAX_LONG_PATH], wlink[MAX_LONG_PATH];
2574+
int len;
2575+
2576+
/* fail if symlinks are disabled or API is not supported (WinXP) */
2577+
if (!has_symlinks) {
2578+
errno = ENOSYS;
2579+
return -1;
2580+
}
2581+
2582+
if ((len = xutftowcs_long_path(wtarget, target)) < 0
2583+
|| xutftowcs_long_path(wlink, link) < 0)
2584+
return -1;
2585+
2586+
/* convert target dir separators to backslashes */
2587+
while (len--)
2588+
if (wtarget[len] == '/')
2589+
wtarget[len] = '\\';
2590+
2591+
/* create file symlink */
2592+
if (!CreateSymbolicLinkW(wlink, wtarget, 0)) {
2593+
errno = err_win_to_posix(GetLastError());
2594+
return -1;
2595+
}
2596+
return 0;
2597+
}
2598+
25712599
#ifndef _WINNT_H
25722600
/*
25732601
* The REPARSE_DATA_BUFFER structure is defined in the Windows DDK (in

compat/mingw.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ struct utsname {
123123
* trivial stubs
124124
*/
125125

126-
static inline int symlink(const char *oldpath, const char *newpath)
127-
{ errno = ENOSYS; return -1; }
128126
static inline int fchmod(int fildes, mode_t mode)
129127
{ errno = ENOSYS; return -1; }
130128
#ifndef __MINGW64_VERSION_MAJOR
@@ -215,6 +213,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out);
215213
int sigaction(int sig, struct sigaction *in, struct sigaction *out);
216214
int link(const char *oldpath, const char *newpath);
217215
int uname(struct utsname *buf);
216+
int symlink(const char *target, const char *link);
218217
int readlink(const char *path, char *buf, size_t bufsiz);
219218

220219
/*

0 commit comments

Comments
 (0)