Skip to content

Commit 9594b32

Browse files
author
Junio C Hamano
committed
Revert "Git.pm: Introduce fast get_object() method"
This reverts commit 3c479c3.
1 parent 3c2f588 commit 9594b32

File tree

2 files changed

+0
-42
lines changed

2 files changed

+0
-42
lines changed

perl/Git.pm

-18
Original file line numberDiff line numberDiff line change
@@ -572,24 +572,6 @@ sub ident_person {
572572
}
573573

574574

575-
=item get_object ( TYPE, SHA1 )
576-
577-
Return contents of the given object in a scalar string. If the object has
578-
not been found, undef is returned; however, do not rely on this! Currently,
579-
if you use multiple repositories at once, get_object() on one repository
580-
_might_ return the object even though it exists only in another repository.
581-
(But do not rely on this behaviour either.)
582-
583-
The method must be called on a repository instance.
584-
585-
Implementation of this method is very fast; no external command calls
586-
are involved. That's why it is broken, too. ;-)
587-
588-
=cut
589-
590-
# Implemented in Git.xs.
591-
592-
593575
=item hash_object ( TYPE, FILENAME )
594576
595577
=item hash_object ( TYPE, FILEHANDLE )

perl/Git.xs

-24
Original file line numberDiff line numberDiff line change
@@ -111,30 +111,6 @@ CODE:
111111
free((char **) argv);
112112
}
113113

114-
115-
SV *
116-
xs_get_object(type, id)
117-
char *type;
118-
char *id;
119-
CODE:
120-
{
121-
unsigned char sha1[20];
122-
unsigned long size;
123-
void *buf;
124-
125-
if (strlen(id) != 40 || get_sha1_hex(id, sha1) < 0)
126-
XSRETURN_UNDEF;
127-
128-
buf = read_sha1_file(sha1, type, &size);
129-
if (!buf)
130-
XSRETURN_UNDEF;
131-
RETVAL = newSVpvn(buf, size);
132-
free(buf);
133-
}
134-
OUTPUT:
135-
RETVAL
136-
137-
138114
char *
139115
xs_hash_object_pipe(type, fd)
140116
char *type;

0 commit comments

Comments
 (0)