Skip to content

Commit f098b17

Browse files
asheidukGit for Windows Build Agent
authored and
Git for Windows Build Agent
committed
Remove support for XP specific config location
Current Git for Windows supports an additional configuration location for system setting. On contemporary versionws of Windows this is $PROGRAMDATA/Git/config. But XP does not know about $PRORGRAMDATA so $ALLUSERSPROFILE/Application Data/Git/config was used. XP itself is EOL for quite some time and Git for Windows ceased to support it officially with version 2.10.0 (release 3 Sep 2016). https://github.com/git-for-windows/git/wiki/FAQ#which-versions-of-windows-are-supported https://git-for-windows.github.io/requirements.html Signed-off-by: Andreas Heiduk <[email protected]>
1 parent 1b6c966 commit f098b17

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

Documentation/git-config.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,7 @@ config file (located at `$PROGRAMDATA/Git/config`), intended to contain
258258
settings for *all* Git-related software running on the machine. Consequently,
259259
this config file takes an even lower precedence than the
260260
`$(prefix)/etc/gitconfig` file. Typically `$PROGRAMDATA` points to
261-
`C:\ProgramData` (on Windows XP the equivalent in `$ALLUSERSPROFILE` is used,
262-
i.e. `C:\Documents and Settings\All Users\Application Data\Git\config`).
261+
`C:\ProgramData`.
263262

264263
If no further options are given, all reading options will read all of these
265264
files that are available. If the global or the system-wide configuration

compat/mingw.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3270,13 +3270,8 @@ const char *program_data_config(void)
32703270

32713271
if (!initialized) {
32723272
const char *env = mingw_getenv("PROGRAMDATA");
3273-
const char *extra = "";
3274-
if (!env) {
3275-
env = mingw_getenv("ALLUSERSPROFILE");
3276-
extra = "/Application Data";
3277-
}
32783273
if (env)
3279-
strbuf_addf(&path, "%s%s/Git/config", env, extra);
3274+
strbuf_addf(&path, "%s/Git/config", env);
32803275
initialized = 1;
32813276
}
32823277
return *path.buf ? path.buf : NULL;

0 commit comments

Comments
 (0)