Skip to content

Commit f28b9f2

Browse files
committed
mingw: demonstrate a problem with certain absolute paths
On Windows, there are several categories of absolute paths. One such category starts with a backslash and is implicitly relative to the drive associated with the current working directory. Example: c: git clone https://github.com/git-for-windows/git \G4W should clone into C:\G4W. There is currently a problem with that, in that mingw_mktemp() does not expect the _wmktemp() function to prefix the absolute path with the drive prefix, and as a consequence, the resulting path does not fit into the originally-passed string buffer. The symptom is a "Result too large" error. Reported by Juan Carlos Arevalo Baeza. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent efdf047 commit f28b9f2

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

t/t5580-clone-push-unc.sh

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,30 @@ fi
1717
UNCPATH="$(winpwd)"
1818
case "$UNCPATH" in
1919
[A-Z]:*)
20+
WITHOUTDRIVE="${UNCPATH#?:}"
2021
# Use administrative share e.g. \\localhost\C$\git-sdk-64\usr\src\git
2122
# (we use forward slashes here because MSYS2 and Git accept them, and
2223
# they are easier on the eyes)
23-
UNCPATH="//localhost/${UNCPATH%%:*}\$/${UNCPATH#?:}"
24-
test -d "$UNCPATH" || {
25-
skip_all='could not access administrative share; skipping'
26-
test_done
27-
}
24+
UNCPATH="//localhost/${UNCPATH%%:*}\$$WITHOUTDRIVE"
2825
;;
2926
*)
3027
skip_all='skipping UNC path tests, cannot determine current path as UNC'
3128
test_done
3229
;;
3330
esac
3431

32+
test_expect_failure 'clone into absolute path lacking a drive prefix' '
33+
USINGBACKSLASHES="$(echo "$WITHOUTDRIVE"/without-drive-prefix |
34+
tr / \\)" &&
35+
git clone . "$USINGBACKSLASHES" &&
36+
test -f without-drive-prefix/.git/HEAD
37+
'
38+
39+
test -d "$UNCPATH" || {
40+
skip_all='could not access administrative share; skipping'
41+
test_done
42+
}
43+
3544
test_expect_success setup '
3645
test_commit initial
3746
'

0 commit comments

Comments
 (0)