spot-instances-request tags breaks on-demand instances

[Giaco9NN]

Hi.
Today we upgraded the module from version 6.4.3 to 6.5.1. Our groups based only on on-demand instances got stuck right after the upgrade. The scale-up lambda silently fails with this error:
"You cannot specify tags for Spot instances requests if there are no Spot instances requests being created by the request."

Below you can see the whole lambda logs:

logs.txt

How can we avoid putting those tags in the launch template when running only on-demand instances?

Thanks!

[npalm]

Thx for reporting, If time allows would you be great if you can raise a PR.

• @konkeramaFYI PR feat: added missing launch template tag_specifications #4544 seems to introduc a bug for non Spot Instance.s.
• If we are not able to roll farward (fix) quickly. I will revert the change asap.

[npalm]

Created a PR, rquires some testing before merging.

[npalm]

Fix available in release https://github.com/github-aws-runners/terraform-aws-github-runner/releases/tag/v6.5.4 should be available

[Giaco9NN]

Hi @npalm, thanks for the help.
I didn't raise a pull request because I wanted to agree on the strategy before implementing it.

Thank you for the help and the rapid fix!