Use lfs from a custom git path if it's there, install if it's missing

Author: shana

build.sh

@@ -29,7 +29,7 @@ fi
 if [ x"$OS" == x"Windows" ]; then
 	common/nuget restore GitHub.Unity.sln
 else
-	nuget restore GitHub.Unity.sln
+	mono common/nuget.exe restore GitHub.Unity.sln
 fi
 
 xbuild GitHub.Unity.sln /verbosity:minimal /property:Configuration=$Configuration /target:$Target || true

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -94,7 +94,7 @@ public ITask InitializeRepository()
 
             var filesForInitialCommit = new List<string> { gitignore, gitAttrs, assetsGitignore };
 
-            var task = 
+            var task =
                 GitClient.Init()
                 .Then(GitClient.SetConfig("merge.unityyamlmerge.cmd", yamlMergeCommand, GitConfigSource.Local))
                 .Then(GitClient.SetConfig("merge.unityyamlmerge.trustExitCode", "false", GitConfigSource.Local))
@@ -203,7 +203,7 @@ private void InitializeEnvironment(GitInstaller.GitInstallationState installatio
             {
                 var credHelperTask = GitClient.GetConfig("credential.helper", GitConfigSource.Global);
                 credHelperTask.OnEnd += (thisTask, credentialHelper, success, exception) =>
-                    {   
+                    {
                         if (!success || string.IsNullOrEmpty(credentialHelper))
                         {
                             Logger.Warning("No Windows CredentialHelper found: Setting to wincred");

src/GitHub.Api/Extensions/EnvironmentExtensions.cs

@@ -1,4 +1,7 @@
 using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
 
 namespace GitHub.Unity
 {
@@ -41,5 +44,15 @@ public static NPath GetAssetPath(this IEnvironment environment, NPath path)
 
             return repositoryPath.Combine(path).MakeAbsolute().RelativeTo(projectPath);
         }
+
+        public static IEnumerable<NPath> ToNPathList(this string envPath, IEnvironment environment)
+        {
+            return envPath
+                    .Split(Path.PathSeparator)
+                    .Where(x => x != null)
+                    .Select(x => environment.ExpandEnvironmentVariables(x.Trim('"', '\'')))
+                    .Where(x => !String.IsNullOrEmpty(x))
+                    .Select(x => x.ToNPath());
+        }
     }
 }

src/GitHub.Api/Extensions/StringExtensions.cs

@@ -82,24 +82,6 @@ public static string JoinForAppending(string separator, IEnumerable<string> valu
                 : string.Empty;
         }
 
-        public static string RemoveSurroundingQuotes(this string s)
-        {
-            Guard.ArgumentNotNull(s, "string");
-
-            if (s.Length < 2)
-                return s;
-
-            var quoteCharacters = new[] { '"', '\'' };
-            char firstCharacter = s[0];
-            if (!quoteCharacters.Contains(firstCharacter))
-                return s;
-
-            if (firstCharacter != s[s.Length - 1])
-                return s;
-
-            return s.Substring(1, s.Length - 2);
-        }
-
         public static string RightAfter(this string s, char search)
         {
             if (s == null) return null;

src/GitHub.Api/Helpers/AssemblyResources.cs

@@ -43,11 +43,13 @@ public static NPath ToFile(ResourceType resourceType, string resource, NPath des
                     return destinationPath.Combine(resource).WriteAllBytes(stream.ToByteArray());
             }
 
-            // check the filesystem
-            NPath possiblePath = environment.ExtensionInstallPath.Combine(type, os, resource);
-            if (possiblePath.FileExists())
-                return possiblePath.Copy(destinationPath.Combine(resource));
-
+            if (!Guard.InUnitTestRunner)
+            {
+                // check the filesystem
+                NPath possiblePath = environment.ExtensionInstallPath.Combine(type, os, resource);
+                if (possiblePath.FileExists())
+                    return possiblePath.Copy(destinationPath.Combine(resource));
+            }
             return NPath.Default;
         }
     }

src/GitHub.Api/IO/NiceIO.cs

@@ -27,13 +27,16 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Text;
 
 namespace GitHub.Unity
 {
     [Serializable]
+    [DebuggerDisplay("{DebuggerDisplay,nq}")]
     public struct NPath : IEquatable<NPath>, IComparable
     {
         public static NPath Default;
@@ -1107,6 +1110,8 @@ private static StringComparison PathStringComparison
                 return _pathStringComparison.Value;
             }
         }
+
+        internal string DebuggerDisplay => ToString();
     }
 
     public static class Extensions