Skip to content

Commit 366c5f9

Browse files
committed
PR Checks: use macos-12 runners for CLI v. < 2.15.1
Prior to CLI v2.15.1, ARM runners were not supported by the build tracer. "macos-latest" is now an ARM runner, so we run these tests on the old CLIs on Intel runners instead.
1 parent 0ad7791 commit 366c5f9

10 files changed

+35
-27
lines changed

.github/workflows/__diagnostics-export.yml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-custom-queries.yml

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-tracing-autobuilder.yml

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-tracing-custom-build-steps.yml

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-tracing-legacy-workflow.yml

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__multi-language-autodetect.yml

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__remote-config.yml

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__resolve-environment-action.yml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__scaling-reserved-ram.yml

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pr-checks/sync.py

+12-4
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,18 @@ def writeHeader(checkStream):
6565
if image.startswith(operatingSystem)]
6666

6767
for runnerImage in runnerImages:
68-
matrix.append({
69-
'os': runnerImage,
70-
'version': version
71-
})
68+
# Prior to CLI v2.15.1, ARM runners were not supported by the build tracer.
69+
# "macos-latest" is now an ARM runner, so we run tests on the old CLIs on Intel runners instead.
70+
if version in ["stable-20230403", "stable-v2.13.4", "stable-v2.13.5", "stable-v2.14.6"] and runnerImage == "macos-latest":
71+
matrix.append({
72+
'os': "macos-12",
73+
'version': version
74+
})
75+
else:
76+
matrix.append({
77+
'os': runnerImage,
78+
'version': version
79+
})
7280

7381
useAllPlatformBundle = "false" # Default to false
7482
if checkSpecification.get('useAllPlatformBundle'):

0 commit comments

Comments
 (0)