Skip to content

Commit 5d444c1

Browse files
committed
Merge branch 'main' into aeisenberg/checkout-path-commitoid
2 parents d068f53 + 6e57bba commit 5d444c1

File tree

130 files changed

+2209
-2074
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

130 files changed

+2209
-2074
lines changed

.github/workflows/__analyze-ref-input.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__debug-artifacts.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__extractor-ram-threads.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-custom-queries.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-custom-tracing-autobuild.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__go-custom-tracing.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__javascript-source-root.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__multi-language-autodetect.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__packaging-config-inputs-js.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__packaging-config-js.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__packaging-inputs-js.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__remote-config.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__rubocop-multi-language.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__split-workflow.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__test-local-codeql.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__test-proxy.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__test-ruby.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__unset-environment.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/__upload-ref-sha-input.yml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/check-expected-release-files.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ jobs:
2020
run: |
2121
bundle_version="$(cat "./src/defaults.json" | jq -r ".bundleVersion")"
2222
set -x
23-
for expected_file in "codeql-bundle.tar.gz" "codeql-bundle-linux64.tar.gz" "codeql-bundle-osx64.tar.gz" "codeql-bundle-win64.tar.gz" "codeql-runner-linux" "codeql-runner-macos" "codeql-runner-win.exe"; do
23+
for expected_file in "codeql-bundle.tar.gz" "codeql-bundle-linux64.tar.gz" "codeql-bundle-osx64.tar.gz" "codeql-bundle-win64.tar.gz"; do
2424
curl --location --fail --head --request GET "https://github.com/github/codeql-action/releases/download/$bundle_version/$expected_file" > /dev/null
2525
done

.github/workflows/pr-checks.yml

+16
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ jobs:
1313
lint-js:
1414
name: Lint
1515
runs-on: ubuntu-latest
16+
timeout-minutes: 45
1617

1718
steps:
1819
- uses: actions/checkout@v2
@@ -21,6 +22,7 @@ jobs:
2122

2223
check-js:
2324
runs-on: ubuntu-latest
25+
timeout-minutes: 45
2426

2527
steps:
2628
- uses: actions/checkout@v2
@@ -30,6 +32,7 @@ jobs:
3032
check-node-modules:
3133
name: Check modules up to date
3234
runs-on: macos-latest
35+
timeout-minutes: 45
3336

3437
steps:
3538
- uses: actions/checkout@v2
@@ -39,6 +42,7 @@ jobs:
3942
verify-pr-checks:
4043
name: Verify PR checks up to date
4144
runs-on: ubuntu-latest
45+
timeout-minutes: 45
4246

4347
steps:
4448
- uses: actions/checkout@v2
@@ -60,6 +64,7 @@ jobs:
6064
matrix:
6165
os: [ubuntu-latest, macos-latest]
6266
runs-on: ${{ matrix.os }}
67+
timeout-minutes: 45
6368

6469
steps:
6570
- uses: actions/checkout@v2
@@ -69,6 +74,7 @@ jobs:
6974
runner-analyze-javascript-ubuntu:
7075
name: Runner ubuntu JS analyze
7176
needs: [check-js, check-node-modules]
77+
timeout-minutes: 45
7278
runs-on: ubuntu-latest
7379

7480
steps:
@@ -97,6 +103,7 @@ jobs:
97103
runner-analyze-javascript-windows:
98104
name: Runner windows JS analyze
99105
needs: [check-js, check-node-modules]
106+
timeout-minutes: 45
100107
runs-on: windows-latest
101108

102109
steps:
@@ -121,6 +128,7 @@ jobs:
121128
runner-analyze-javascript-macos:
122129
name: Runner macos JS analyze
123130
needs: [check-js, check-node-modules]
131+
timeout-minutes: 45
124132
runs-on: macos-latest
125133

126134
steps:
@@ -145,6 +153,7 @@ jobs:
145153
runner-analyze-csharp-ubuntu:
146154
name: Runner ubuntu C# analyze
147155
needs: [check-js, check-node-modules]
156+
timeout-minutes: 45
148157
runs-on: ubuntu-latest
149158

150159
steps:
@@ -184,6 +193,7 @@ jobs:
184193
needs: [check-js, check-node-modules]
185194
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
186195
# `windows-latest`.
196+
timeout-minutes: 45
187197
runs-on: windows-2019
188198

189199
steps:
@@ -228,6 +238,7 @@ jobs:
228238

229239
runner-analyze-csharp-macos:
230240
name: Runner macos C# analyze
241+
timeout-minutes: 45
231242
needs: [check-js, check-node-modules]
232243
runs-on: macos-latest
233244

@@ -266,6 +277,7 @@ jobs:
266277

267278
runner-analyze-csharp-autobuild-ubuntu:
268279
name: Runner ubuntu autobuild C# analyze
280+
timeout-minutes: 45
269281
needs: [check-js, check-node-modules]
270282
runs-on: ubuntu-latest
271283

@@ -301,6 +313,7 @@ jobs:
301313
TEST_MODE: true
302314

303315
runner-analyze-csharp-autobuild-windows:
316+
timeout-minutes: 45
304317
name: Runner windows autobuild C# analyze
305318
needs: [check-js, check-node-modules]
306319
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
@@ -343,6 +356,7 @@ jobs:
343356
name: Runner macos autobuild C# analyze
344357
needs: [check-js, check-node-modules]
345358
runs-on: macos-latest
359+
timeout-minutes: 45
346360

347361
steps:
348362
- uses: actions/checkout@v2
@@ -380,6 +394,7 @@ jobs:
380394
name: Runner upload sarif
381395
needs: [check-js, check-node-modules]
382396
runs-on: ubuntu-latest
397+
timeout-minutes: 45
383398

384399
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.base.repo.id == github.event.pull_request.head.repo.id }}
385400

@@ -402,6 +417,7 @@ jobs:
402417
name: Runner ubuntu extractor RAM and threads options
403418
needs: [check-js, check-node-modules]
404419
runs-on: ubuntu-latest
420+
timeout-minutes: 45
405421

406422
steps:
407423
- uses: actions/checkout@v2

.github/workflows/python-deps.yml

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ on:
1010

1111
jobs:
1212
test-setup-python-scripts:
13+
timeout-minutes: 45
1314
runs-on: ${{ matrix.os }}
1415
strategy:
1516
fail-fast: false

.github/workflows/release-runner.yml

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99

1010
jobs:
1111
release-runner:
12+
timeout-minutes: 45
1213
runs-on: ubuntu-latest
1314
env:
1415
RELEASE_TAG: "${{ github.event.inputs.bundle-tag }}"

.github/workflows/split.yml

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ on:
2626
jobs:
2727
build:
2828
runs-on: ubuntu-latest
29+
timeout-minutes: 45
2930
env:
3031
CLI_RELEASE: "${{ github.event.inputs.cli-release }}"
3132
RELEASE_TAG: "${{ github.event.inputs.bundle-tag }}"

.github/workflows/update-dependencies.yml

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
jobs:
77
update:
88
name: Update dependencies
9+
timeout-minutes: 45
910
runs-on: macos-latest
1011
if: contains(github.event.pull_request.labels.*.name, 'Update dependencies') && (github.event.pull_request.head.repo.full_name == 'github/codeql-action')
1112
steps:

.github/workflows/update-release-branch.yml

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99

1010
jobs:
1111
update:
12+
timeout-minutes: 45
1213
runs-on: ubuntu-latest
1314
if: ${{ github.repository == 'github/codeql-action' }}
1415
steps:

.github/workflows/update-supported-enterprise-server-versions.yml

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ on:
66

77
jobs:
88
update-supported-enterprise-server-versions:
9+
name: Update Supported Enterprise Server Versions
10+
timeout-minutes: 45
911
runs-on: ubuntu-latest
1012
if: ${{ github.repository == 'github/codeql-action' }}
1113

CHANGELOG.md

+15-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,21 @@
1-
# CodeQL Action and CodeQL Runner Changelog
1+
# CodeQL Action Changelog
22

33
## [UNRELEASED]
44

5-
- Update default CodeQL bundle version to 2.8.2.
6-
- Fix a bug where old results can be uploaded if the languages in a repository change when using a non-ephemeral self-hosted runner.
5+
No user facing changes.
6+
7+
## 1.1.5 - 15 Mar 2022
8+
9+
- Update default CodeQL bundle version to 2.8.3.
10+
- The CodeQL runner is now deprecated and no longer being released. For more information, see [CodeQL runner deprecation](https://github.blog/changelog/2021-09-21-codeql-runner-deprecation/).
11+
- Fix two bugs that cause action failures with GHES 3.3 or earlier. [#978](https://github.com/github/codeql-action/pull/978)
12+
- Fix `not a permitted key` invalid requests with GHES 3.1 or earlier
13+
- Fix `RUNNER_ARCH environment variable must be set` errors with GHES 3.3 or earlier
14+
15+
## 1.1.4 - 07 Mar 2022
16+
17+
- Update default CodeQL bundle version to 2.8.2. [#950](https://github.com/github/codeql-action/pull/950)
18+
- Fix a bug where old results can be uploaded if the languages in a repository change when using a non-ephemeral self-hosted runner. [#955](https://github.com/github/codeql-action/pull/955)
719

820
## 1.1.3 - 23 Feb 2022
921

CONTRIBUTING.md

+20-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Here are a few things you can do that will increase the likelihood of your pull
6363
1. The first step of releasing a new version of the `codeql-action` is running the "Update release branch" workflow.
6464
This workflow goes through the pull requests that have been merged to `main` since the last release, creates a changelog, then opens a pull request to merge the changes since the last release into the `v1` release branch.
6565

66-
A release is automatically started every Monday via a scheduled run of this workflow, however you can start a release manually by triggering a run via [workflow dispatch](https://github.com/github/codeql-action/actions/workflows/update-release-branch.yml).
66+
A release is automatically started every Monday via a scheduled run of this workflow, however you can start a release manually by triggering a run via [workflow dispatch](https://github.com/github/codeql-action/actions/workflows/update-release-branch.yml).
6767
1. The workflow run will open a pull request titled "Merge main into v1". Mark the pull request as [ready for review](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review) to trigger the PR checks.
6868
1. Review the checklist items in the pull request description.
6969
Once you've checked off all but the last of these, approve the PR and automerge it.
@@ -72,6 +72,25 @@ Here are a few things you can do that will increase the likelihood of your pull
7272

7373
Approve the mergeback PR and automerge it. Once the mergeback has been merged into main, the release is complete.
7474

75+
## Keeping the PR checks up to date (admin access required)
76+
77+
Since the `codeql-action` runs most of its testing through individual Actions workflows, there are over two hundred jobs that need to pass in order for a PR to turn green. Managing these PR checks manually is time consuming and complex. Here is a semi-automated approach.
78+
79+
To regenerate the PR jobs for the action:
80+
81+
1. From a terminal, run the following commands (replace `SHA` with the sha of the commit whose checks you want to use, typically this should be the latest from `main`):
82+
83+
```sh
84+
SHA= ####
85+
CHECKS="$(gh api repos/github/codeql-action/commits/${SHA}/check-runs --paginate | jq --slurp --compact-output --raw-output '[.[].check_runs | .[].name | select(contains("https://") or . == "CodeQL" or . == "LGTM.com" or . == "Update dependencies" or . == "Update Supported Enterprise Server Versions" | not)]')"
86+
echo "{\"contexts\": ${CHECKS}}" > checks.json
87+
gh api -X "PATCH" repos/github/codeql-action/branches/main/protection/required_status_checks --input checks.json
88+
gh api -X "PATCH" repos/github/codeql-action/branches/v1/protection/required_status_checks --input checks.json
89+
````
90+
91+
2. Go to the [branch protection rules settings page](https://github.com/github/codeql-action/settings/branches) and validate that the rules have been updated.
92+
93+
7594
## Resources
7695

7796
- [How to Contribute to Open Source](https://opensource.guide/how-to-contribute/)

0 commit comments

Comments
 (0)