Skip to content

Commit 9a8503f

Browse files
committed
Update changelog
1 parent 21b4b43 commit 9a8503f

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CHANGELOG.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the
66

77
## [UNRELEASED]
88

9-
No user facing changes.
9+
- Avoid printing out a warning for a missing `on.push` trigger when the CodeQL Action is triggered via a `workflow_call` event. [#2274](https://github.com/github/codeql-action/pull/2274)
1010

1111
## 3.25.3 - 25 Apr 2024
1212

@@ -30,7 +30,7 @@ No user facing changes.
3030

3131
- The `setup-python-dependencies` input to the `init` Action
3232
- The `CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION` environment variable
33-
33+
3434
We recommend removing any references to these from your workflows. For more information, see the release notes for CodeQL Action v3.23.0 and v2.23.0.
3535
- Automatically overwrite an existing database if found on the filesystem. [#2229](https://github.com/github/codeql-action/pull/2229)
3636
- Bump the minimum CodeQL bundle version to 2.12.6. [#2232](https://github.com/github/codeql-action/pull/2232)

lib/workflow.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/workflow.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ export async function getWorkflowErrors(
223223
// Avoid warning when there this action was triggered via workflow_call since
224224
// the user has a custom workflow that is calling this action and we assume
225225
// they know what they are doing.
226-
const isWorkflowCall = github.context.eventName === "workflow_call"
226+
const isWorkflowCall = github.context.eventName === "workflow_call";
227227

228228
if (missingPush && !isWorkflowCall) {
229229
errors.push(WorkflowErrors.MissingPushHook);

0 commit comments

Comments
 (0)