Skip to content

Commit c6c7d29

Browse files
authored
Clarify merging with merge commit (#1291)
* Clarify merging with merge commit * Add merge commit message to mergeback PRs
1 parent 3d39294 commit c6c7d29

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/update-release-branch.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def open_pr(
104104
body.append(' - [ ] Wait for the "Update dependencies" workflow to push a commit updating the dependencies.')
105105
body.append(' - [ ] Mark the PR as ready for review to trigger the full set of PR checks.')
106106

107-
body.append(' - [ ] Approve and merge this PR.')
107+
body.append(' - [ ] Approve and merge this PR. Make sure `Create a merge commit` is selected rather than `Squash and merge` or `Rebase and merge`.')
108108

109109
if is_v2_release:
110110
body.append(' - [ ] Merge the mergeback PR that will automatically be created once this PR is merged.')

.github/workflows/post-release-mergeback.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ jobs:
122122
- [ ] Remove and re-add the "Update dependencies" label to the PR to trigger just this workflow.
123123
- [ ] Wait for the "Update dependencies" workflow to push a commit updating the dependencies.
124124
- [ ] Mark the PR as ready for review to trigger the full set of PR checks.
125-
- [ ] Approve and merge the PR.
125+
- [ ] Approve and merge the PR. Make sure `Create a merge commit` is selected rather than `Squash and merge` or `Rebase and merge`.
126126
EOF
127127
)
128128

0 commit comments

Comments
 (0)