Cross-check Go binary in analyze Action

Author: mbg

lib/analyze-action.js

@@ -3,6 +3,7 @@ import path from "path";
 import { performance } from "perf_hooks";
 
 import * as core from "@actions/core";
+import { safeWhich } from "@chrisgavin/safe-which";
 
 import * as actionsUtil from "./actions-util";
 import {
@@ -236,6 +237,19 @@ async function run() {
       logger,
     );
 
+    // Check that the Go wrapper script still exists, if set
+    const goWrapperPath = process.env[EnvVar.GO_BINARY_LOCATION];
+
+    if (goWrapperPath !== undefined) {
+      const goBinaryPath = await safeWhich("go");
+
+      if (goWrapperPath !== goBinaryPath) {
+        core.warning(
+          "Unexpected result for `which go`: please ensure that the correct version of Go is installed before the `codeql-action/init` Action is used.",
+        );
+      }
+    }
+
     await runAutobuildIfLegacyGoWorkflow(config, logger);
 
     dbCreationTimings = await runFinalize(

lib/analyze-action.js.map

@@ -0,0 +1,35 @@
+import test from "ava";
+
+import { ResolveBuildEnvironmentOutput } from "./codeql";
+import * as resolveEnvironment from "./resolve-environment";
+
+test("inferRunnerImage inserts runnerImage key", async (t) => {
+  t.assert(
+    resolveEnvironment.inferRunnerImage({ name: "windows" }).runnerImage ===
+      "windows-latest",
+    "Result does not contain expected runnerImage"
+  );
+  t.assert(
+    resolveEnvironment.inferRunnerImage({ name: "linux" }).runnerImage ===
+      "ubuntu-latest",
+    "Result does not contain expected runnerImage"
+  );
+  t.assert(
+    resolveEnvironment.inferRunnerImage({ name: "macos" }).runnerImage ===
+      "macos-latest",
+    "Result does not contain expected runnerImage"
+  );
+});
+
+test("inferRunnerImages inserts runnerImage keys", async (t) => {
+  const testData: ResolveBuildEnvironmentOutput = {
+    configuration: {
+      csharp: { os: { name: "windows" } },
+      swift: { os: { name: "macos" } },
+    },
+  };
+  resolveEnvironment.inferRunnerImages(testData);
+
+  t.assert(testData.configuration?.csharp.os?.runnerImage, "blerg");
+
+});