ruby: fix spurious alert

Author: yoff

Diff for: ruby/ql/src/queries/variables/UninitializedLocal.ql

@@ -82,6 +82,7 @@ class RelevantLocalVariableReadAccess extends LocalVariableReadAccess {
     not exists(ConditionalExpr c | factor(c.getCondition(), this.getVariable().getAnAccess()) |
       this = c.getBranch(true).getAChild*()
     ) and
+    not exists(ConditionalLoop l | factor(l.getCondition(), evaluatingMention(this))) and
     not loopProtects(_, this)
   }
 }

Diff for: ruby/ql/test/query-tests/variables/UninitializedLocal/UninitializedLocal.expected

@@ -1,3 +1,2 @@
 | UninitializedLocal.rb:12:5:12:5 | m | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:8:9:8:9 | m | m |
 | UninitializedLocal.rb:17:18:17:18 | a | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:17:9:17:9 | a | a |
-| UninitializedLocal.rb:35:15:35:15 | a | Local variable $@ may be used before it is initialized. | UninitializedLocal.rb:31:13:31:13 | a | a |

Diff for: ruby/ql/test/query-tests/variables/UninitializedLocal/UninitializedLocal.rb

@@ -32,6 +32,6 @@ def test_loop
         else
             set_a
         end   
-    end until a  #$ SPURIOUS: Alert
+    end until a  # OK
     a  # OK - given previous until
 end