Skip to content

Commit 759a37b

Browse files
authored
Merge pull request #395 from github/kh-bump-eslint-dependency
Bump eslint-plugin-jsx-a11y to 6.7.1
2 parents 11b66bf + 019e11e commit 759a37b

File tree

5 files changed

+13
-6
lines changed

5 files changed

+13
-6
lines changed

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -93,5 +93,4 @@ This config will be interpreted in the following way:
9393

9494
#### Accessibility-focused rules (prefixed with a11y)
9595

96-
- [No Generic Link Text](./docs/rules/a11y-no-generic-link-text.md)
9796
- [Role Supports ARIA Props](./docs/rules/role-supports-aria-props.md)

docs/rules/a11y-no-generic-link-text.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
# No Generic Link Text
1+
# No Generic Link Text [Deprecated]
2+
3+
_This rule has been deprecated in favor of `anchor-ambiguous-text` in `eslint-plugin-jsx-a11y`._
24

35
## Rule Details
46

lib/configs/react.js

+8-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,14 @@ module.exports = {
88
plugins: ['github', 'jsx-a11y'],
99
extends: ['plugin:jsx-a11y/recommended'],
1010
rules: {
11-
'github/a11y-no-generic-link-text': 'error',
11+
'jsx-a11y/role-supports-aria-props': 'off', // Override with github/role-supports-aria-props until https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/910 is resolved
1212
'github/role-supports-aria-props': 'error',
13-
'jsx-a11y/role-supports-aria-props': 'off',
13+
'jsx-a11y/no-aria-hidden-on-focusable': 'error',
14+
'jsx-a11y/anchor-ambiguous-text': [
15+
'error',
16+
{
17+
words: ['this', 'more', 'read here', 'read more'],
18+
},
19+
],
1420
},
1521
}

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"eslint-plugin-filenames": "^1.3.2",
3636
"eslint-plugin-i18n-text": "^1.0.1",
3737
"eslint-plugin-import": "^2.25.2",
38-
"eslint-plugin-jsx-a11y": "^6.6.0",
38+
"eslint-plugin-jsx-a11y": "^6.7.1",
3939
"eslint-plugin-no-only-tests": "^3.0.0",
4040
"eslint-plugin-prettier": "^4.0.0",
4141
"eslint-rule-documentation": ">=1.0.0",

0 commit comments

Comments
 (0)