wip: Don't print referecence count when no reference is traversed

Author: elhmn

Diff for: git-sizer.go

@@ -343,14 +343,18 @@ func mainImplementation(ctx context.Context, stdout, stderr io.Writer, args []st
 		return fmt.Errorf("error scanning repository: %w", err)
 	}
 
+	formatOptions := sizes.FormatOptions{
+		WithoutReferenceCount: git.IsNoReferencesFilter(rgb.GetTopLevelGroup().GetFilter()),
+	}
+
 	if jsonOutput {
 		var j []byte
 		var err error
 		switch jsonVersion {
 		case 1:
 			j, err = json.MarshalIndent(historySize, "", "    ")
 		case 2:
-			j, err = historySize.JSON(rg.Groups(), threshold, nameStyle)
+			j, err = historySize.JSON(rg.Groups(), threshold, nameStyle, formatOptions)
 		default:
 			return fmt.Errorf("JSON version must be 1 or 2")
 		}
@@ -360,7 +364,7 @@ func mainImplementation(ctx context.Context, stdout, stderr io.Writer, args []st
 		fmt.Fprintf(stdout, "%s\n", j)
 	} else {
 		if _, err := io.WriteString(
-			stdout, historySize.TableString(rg.Groups(), threshold, nameStyle),
+			stdout, historySize.TableString(rg.Groups(), threshold, nameStyle, formatOptions),
 		); err != nil {
 			return fmt.Errorf("writing output: %w", err)
 		}

Diff for: sizes/output.go

@@ -86,22 +86,22 @@ type section struct {
 	contents []tableContents
 }
 
-func newSection(name string, contents ...tableContents) *section {
-	return &section{
+func newSection(name string, contents ...tableContents) section {
+	return section{
 		name:     name,
 		contents: contents,
 	}
 }
 
-func (s *section) Emit(t *table) {
+func (s section) Emit(t *table) {
 	for _, c := range s.contents {
 		subTable := t.subTable(s.name)
 		c.Emit(subTable)
 		t.addSection(subTable)
 	}
 }
 
-func (s *section) CollectItems(items map[string]*item) {
+func (s section) CollectItems(items map[string]*item) {
 	for _, c := range s.contents {
 		c.CollectItems(items)
 	}
@@ -141,7 +141,7 @@ func newItem(
 	}
 }
 
-func (i *item) Emit(t *table) {
+func (i item) Emit(t *table) {
 	levelOfConcern, interesting := i.levelOfConcern(t.threshold)
 	if !interesting {
 		return
@@ -154,7 +154,7 @@ func (i *item) Emit(t *table) {
 	)
 }
 
-func (i *item) Footnote(nameStyle NameStyle) string {
+func (i item) Footnote(nameStyle NameStyle) string {
 	if i.path == nil || i.path.OID == git.NullOID {
 		return ""
 	}
@@ -173,7 +173,7 @@ func (i *item) Footnote(nameStyle NameStyle) string {
 // If this item's alert level is at least as high as the threshold,
 // return the string that should be used as its "level of concern" and
 // `true`; otherwise, return `"", false`.
-func (i *item) levelOfConcern(threshold Threshold) (string, bool) {
+func (i item) levelOfConcern(threshold Threshold) (string, bool) {
 	value, overflow := i.value.ToUint64()
 	if overflow {
 		return "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!", true
@@ -188,11 +188,11 @@ func (i *item) levelOfConcern(threshold Threshold) (string, bool) {
 	return stars[:int(alert)], true
 }
 
-func (i *item) CollectItems(items map[string]*item) {
-	items[i.symbol] = i
+func (i item) CollectItems(items map[string]*item) {
+	items[i.symbol] = &i
 }
 
-func (i *item) MarshalJSON() ([]byte, error) {
+func (i item) MarshalJSON() ([]byte, error) {
 	// How we want to emit an item as JSON.
 	value, _ := i.value.ToUint64()
 
@@ -224,7 +224,7 @@ func (i *item) MarshalJSON() ([]byte, error) {
 
 // Indented returns an `item` that is just like `i`, but indented by
 // `depth` more levels.
-func (i *item) Indented(depth int) tableContents {
+func (i item) Indented(depth int) tableContents {
 	return &indentedItem{
 		tableContents: i,
 		depth:         depth,
@@ -236,7 +236,7 @@ type indentedItem struct {
 	depth int
 }
 
-func (i *indentedItem) Emit(t *table) {
+func (i indentedItem) Emit(t *table) {
 	subTable := t.indented("", i.depth)
 	i.tableContents.Emit(subTable)
 	t.addSection(subTable)
@@ -373,8 +373,9 @@ type table struct {
 
 func (s *HistorySize) TableString(
 	refGroups []RefGroup, threshold Threshold, nameStyle NameStyle,
+	opts FormatOptions,
 ) string {
-	contents := s.contents(refGroups)
+	contents := s.contents(refGroups, opts)
 	t := table{
 		threshold: threshold,
 		nameStyle: nameStyle,
@@ -454,17 +455,20 @@ func (t *table) formatRow(
 	)
 }
 
+type FormatOptions struct {
+	WithoutReferenceCount bool
+}
+
 func (s *HistorySize) JSON(
-	refGroups []RefGroup, threshold Threshold, nameStyle NameStyle,
-) ([]byte, error) {
-	contents := s.contents(refGroups)
+	refGroups []RefGroup, threshold Threshold, nameStyle NameStyle, opts FormatOptions) ([]byte, error) {
+	contents := s.contents(refGroups, opts)
 	items := make(map[string]*item)
 	contents.CollectItems(items)
 	j, err := json.MarshalIndent(items, "", "    ")
 	return j, err
 }
 
-func (s *HistorySize) contents(refGroups []RefGroup) tableContents {
+func (s *HistorySize) contents(refGroups []RefGroup, opts FormatOptions) tableContents {
 	S := newSection
 	I := newItem
 	metric := counts.Metric
@@ -489,6 +493,20 @@ func (s *HistorySize) contents(refGroups []RefGroup) tableContents {
 		rgis = append(rgis, rgi.Indented(indent))
 	}
 
+	var refCountSection section
+	if !opts.WithoutReferenceCount {
+		refCountSection = S(
+			"References",
+			I("referenceCount", "Count",
+				"The total number of references",
+				nil, s.ReferenceCount, metric, "", 25e3),
+			S(
+				"",
+				rgis...,
+			),
+		)
+	}
+
 	return S(
 		"",
 		S(
@@ -533,16 +551,7 @@ func (s *HistorySize) contents(refGroups []RefGroup) tableContents {
 					nil, s.UniqueTagCount, metric, "", 25e3),
 			),
 
-			S(
-				"References",
-				I("referenceCount", "Count",
-					"The total number of references",
-					nil, s.ReferenceCount, metric, "", 25e3),
-				S(
-					"",
-					rgis...,
-				),
-			),
+			refCountSection,
 		),
 
 		S("Biggest objects",