Skip to content

Commit 931dbeb

Browse files
authored
Merge pull request #24 from github/no-more-then-six-levels-of-headers
No more then six levels of headers
2 parents 0599d0e + 762cdf0 commit 931dbeb

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

index.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ class MarkdownHeaderButtonElement extends MarkdownButtonElement {
4545
super()
4646

4747
const level = parseInt(this.getAttribute('level') || 3, 10)
48+
if (level < 1 || level > 6) {
49+
return
50+
}
51+
4852
const prefix = `${'#'.repeat(level)} `
4953
styles.set(this, {
5054
prefix

test/test.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ describe('markdown-toolbar-element', function() {
7171
<md-bold>bold</md-bold>
7272
<md-header>header</md-header>
7373
<md-header level="1">h1</md-header>
74+
<md-header level="10">h1</md-header>
7475
<md-italic>italic</md-italic>
7576
<md-quote>quote</md-quote>
7677
<md-code>code</md-code>
@@ -497,11 +498,18 @@ describe('markdown-toolbar-element', function() {
497498
clickToolbar('md-header')
498499
assert.equal('### |title|', visualValue())
499500
})
501+
500502
it('inserts header 1 syntax with cursor in description', function() {
501503
setVisualValue('|title|')
502504
clickToolbar('md-header[level="1"]')
503505
assert.equal('# |title|', visualValue())
504506
})
507+
508+
it('does not insert header for invalid level', function() {
509+
setVisualValue('|title|')
510+
clickToolbar('md-header[level="10"]')
511+
assert.equal('|title|', visualValue())
512+
})
505513
})
506514
})
507515
})

0 commit comments

Comments
 (0)