From a5624f14d54ac6a364e696e45b94d2ee9257a5e4 Mon Sep 17 00:00:00 2001 From: Sam Partington Date: Mon, 13 Sep 2021 14:10:11 +0100 Subject: [PATCH] Require pressing shift for the quote hotkey This is to avoid conflicting with github's existing saved-reply shortcut --- src/index.ts | 1 + test/test.js | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/index.ts b/src/index.ts index f8a3668..fd2cbcc 100644 --- a/src/index.ts +++ b/src/index.ts @@ -173,6 +173,7 @@ class MarkdownQuoteButtonElement extends MarkdownButtonElement { connectedCallback() { super.connectedCallback() this.setAttribute('hotkey', '.') + this.setAttribute('hotkey-requires-shift', 'true') } } diff --git a/test/test.js b/test/test.js index f580a4a..c991867 100644 --- a/test/test.js +++ b/test/test.js @@ -468,10 +468,12 @@ describe('markdown-toolbar-element', function () { assert.equal('> |', visualValue()) }) - it('inserts selected quoted sample via hotkey', function () { + it('inserts selected quoted sample via hotkey, requiring shift', function () { focus() setVisualValue('') - pressHotkey('.') + pressHotkey('.', false) + assert.equal('|', visualValue()) + pressHotkey('.', true) assert.equal('> |', visualValue()) })