Skip to content

Document how header slugs get generated #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jedwards1211 opened this issue Feb 7, 2020 · 3 comments
Closed

Document how header slugs get generated #1326

jedwards1211 opened this issue Feb 7, 2020 · 3 comments
Labels

Comments

@jedwards1211
Copy link

jedwards1211 commented Feb 7, 2020

I have headers in my repo https://github.com/vscodeshift/material-ui-snippets like

### `mui-app-bar-menu`: <AppBar> with menu icon

The slug GitHub generates for this is

#mui-app-bar-menu-appbar-with-menu-icon

But many libs like github-slugger and markdown-toc don't currently strip away HTML entities, instead generating

#mui-app-bar-menu-ltappbargt-with-menu-icon

I PRed a fix to both these libs, but this points to the need for a concrete specification of what GitHub is doing, so that we can guarantee correct output in tools like these.

@UziTech
Copy link

UziTech commented Mar 31, 2021

@zeke wondering if you ever got an answer for Flet/github-slugger#25 (comment)

@zeke
Copy link

zeke commented Apr 1, 2021

Sorry, I don't remember. 🤔

Copy link

github-actions bot commented Nov 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants