Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation check hangs if multiple suborgs matched repositories #790

Open
grossag opened this issue Mar 20, 2025 · 1 comment
Open

Validation check hangs if multiple suborgs matched repositories #790

grossag opened this issue Mar 20, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@grossag
Copy link

grossag commented Mar 20, 2025

Problem Description

What is actually happening

During app validation, if the new logic in a692dbf catches a match for multiple suborgs, the check is not correctly failed.

What is the expected behavior

  • The check fails with the appropriate error message.
  • Optionally, a PR comment is created

Error output, if available

2025-03-18T03:44:43.962000: ERROR (event): NOPCOMMAND {"type":"ERROR","plugin":"getSubOrgConfigs","repo":"safe-settings-config","endpoint":"","body":"","action":{"msg":"Error: Multiple suborg configs for devframework.bom-test-project in .github/suborgs/hcs-devfw.yml and .github/suborgs/hcs-devframework.yml","additions":null,"modifications":null,"deletions":null}}

Context

Are you using the hosted instance of probot/settings or running your own?

Running our own

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

I believe we are on 2.1.16, but I'm not 100% sure.

Version of GitHub Enterprise

N/A (on GitHub Enterprise Cloud)

@grossag grossag added the bug Something isn't working label Mar 20, 2025
@grossag
Copy link
Author

grossag commented Mar 20, 2025

Screenshot: Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant