Skip to content

Commit 593c013

Browse files
committed
Update outdated VS Code version docs
There were still references to a pinned version of VS Code used in the integration tests, but this was resolved in #2877.
1 parent cce0e14 commit 593c013

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/node-version.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ npx ts-node scripts/update-node-version.ts
2323

2424
Unit tests will use whatever version of Node.js is installed locally. In CI this will be the version specified in the workflow.
2525

26-
Integration tests download a copy of VS Code and then will use whatever version of Node.js is provided by VS Code. Our integration tests are currently pinned to an older version of VS Code. See [VS Code version used in tests](./vscode-version.md#vs-code-version-used-in-tests) for more information.
26+
Integration tests download a copy of VS Code and then will use whatever version of Node.js is provided by VS Code. See [VS Code version used in tests](./vscode-version.md#vs-code-version-used-in-tests) for more information.

docs/vscode-version.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,6 @@ npx update-browserslist-db@latest
5050

5151
## VS Code version used in tests
5252

53-
Our integration tests are currently pinned to use an older version of VS Code due to <https://github.com/github/vscode-codeql/issues/2402>.
54-
This version is specified in [`jest-runner-vscode.config.base.js`](https://github.com/github/vscode-codeql/blob/d93f2b67c84e79737b0ce4bb74e31558b5f5166e/extensions/ql-vscode/test/vscode-tests/jest-runner-vscode.config.base.js#L17).
55-
Until this is resolved this will limit us updating our minimum supported version of VS Code.
53+
The integration tests use the latest stable version of VS Code. This is specified in
54+
the [`test/vscode-tests/jest-runner-vscode.config.base.js`](https://github.com/github/vscode-codeql/blob/main/extensions/ql-vscode/test/vscode-tests/jest-runner-vscode.config.base.js#L15)
55+
file. This shouldn't need to be updated unless there is a breaking change in VS Code that prevents the tests from running.

0 commit comments

Comments
 (0)