Not filtering by excluded handle (GHE)

[grahamj]

🔍 Is there already an issue for your problem?

• I have checked older issues, open and closed

📝 Description

I have a handle exclusion specified in filters yet am still receiving notifications for PRs from that user.

PS thanks for Gitify, love it!

🪜 Steps To Reproduce

1. Using GitHub Enterprise account
2. Ensure detailed notifications is on
3. Add a handle to exclude
4. Create a PR or other notification with that user
5. Notification appears in list

🪵 Log Excerpts

No response

Gitify Version

6.1.0

Operating System

macOS

GitHub Account

GitHub Enterprise Server

📸 Screenshots

[setchy]

@grahamj - in your settings is detailed notifications enabled or disabled?

[grahamj]

@grahamj - in your settings is detailed notifications enabled or disabled?

I do have that enabled.

[setchy]

Thanks @grahamj - I missed you had mentioned this in your original issue - apologies.

I haven't been able to reproduce the above on my side this morning with GitHub Cloud notifications.

If you are able to run gitify from source and debug the following that would be helpful. From the screenshots you provided, notification.subject.user.login should be bender

gitify/src/renderer/utils/notifications/filters/filter.ts

Lines 29 to 33 in 649ce40

	if (hasExcludeHandleFilters(settings)) {
	return !settings.filterExcludeHandles.some((handle) =>
	filterNotificationByHandle(notification, handle),
	);
	}

[grahamj]

ok maybe it's a GHE thing. I'll give it a whirl and get back.

[grahamj]

Actually is there a way to pop open the developer tools from the app? I could probably figure out what’s going on just by snooping the request.

nvm, I found option-cmd-i

[grahamj]

Alright I see the issue: you're looking for subject?.user?.login in the notification response:

gitify/src/renderer/utils/notifications/filters/handles.ts

Line 16 in 649ce40

return notification.subject?.user?.login === handleName;

but in my response the subject doesn't have a user property at all:

[
  {
    "id": "REDACTED",
    "unread": true,
    "reason": "review_requested",
    "updated_at": "2025-02-20T11:06:14Z",
    "last_read_at": "2025-02-19T21:29:37Z",
    "subject": {
      "title": "Lock file maintenance",
      "url": "REDACTED",
      "latest_comment_url": null,
      "type": "PullRequest"
    },
   ...

Unfortunately the handle doesn't appear anywhere else in that payload either. However it looks like you're requesting information about each PR too and the handle does appear there. If you're able to filter on user.login in the PR response that would do the trick.

[setchy]

When the detailed notifications flag is enabled, we do a bunch of enrichment to the raw response, including adding in the user details along with other data points back into the subject object.

gitify/src/renderer/utils/subject.ts

Lines 29 to 59 in 88bdc1b

	export async function getGitifySubjectDetails(
	notification: Notification,
	): Promise<GitifySubject> {
	try {
	switch (notification.subject.type) {
	case 'CheckSuite':
	return getGitifySubjectForCheckSuite(notification);
	case 'Commit':
	return getGitifySubjectForCommit(notification);
	case 'Discussion':
	return await getGitifySubjectForDiscussion(notification);
	case 'Issue':
	return await getGitifySubjectForIssue(notification);
	case 'PullRequest':
	return await getGitifySubjectForPullRequest(notification);
	case 'Release':
	return await getGitifySubjectForRelease(notification);
	case 'WorkflowRun':
	return getGitifySubjectForWorkflowRun(notification);
	default:
	return null;
	}
	} catch (err) {
	logError(
	'getGitifySubjectDetails',
	'failed to fetch details for notification for',
	err,
	notification,
	);
	}
	}

[grahamj]

ah ok, if you're merging user from the PR request into subject prior to filtering then I would expect this to work.

oh hold on, doesn't this being first mean if I have user type filters the excludes will not be evaluated?

gitify/src/renderer/utils/notifications/filters/filter.ts

Line 17 in 649ce40

if (hasUserTypeFilters(settings)) {

[grahamj]

yeah that's it, if I turn off the user type filter it works

I think the logic there needs to be reworked - you can return immediately if the handle is excluded but for the other things you only want to return if there's not a match so they're effectively ANDed. I'd probably just have a "pass" flag and return it at the end.

[grahamj]

Thanks very much!