Skip to content

[BUG] There's a broken icon when used with GHE #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LunaticMuch opened this issue Mar 21, 2023 · 7 comments · Fixed by #913
Closed

[BUG] There's a broken icon when used with GHE #564

LunaticMuch opened this issue Mar 21, 2023 · 7 comments · Fixed by #913
Assignees
Labels
bug Something isn't working

Comments

@LunaticMuch
Copy link

I found this broken icon, and it feels like a bug.

I am happy to work and fix it, but wondering if this project is being maintained or not as the feeling seems no.
@manosim do you look for help?

Screenshot 2023-03-21 at 17 56 51

@afonsojramos
Copy link
Member

Hey @LunaticMuch! Does this still happen? Do you happen to know which icon this might be?

@afonsojramos afonsojramos added bug Something isn't working needs-triage labels May 22, 2023
@LunaticMuch
Copy link
Author

@afonsojramos wow I missed this.
I can check. TBH I had deinstalled Gitify, I had the feeling the project was not moving.

@bmulholland
Copy link
Collaborator

The project indeed was not moving, but @afonsojramos has picked it up and is getting things moving again 🎉

@LunaticMuch
Copy link
Author

Thanks. I updated today to version v4.4 and the bug is still there. Can I help some debug?

@afonsojramos
Copy link
Member

@LunaticMuch Yeah, if we could know what was the type of notification that would be great! But it is indeed weird because we have defaults in place for "unknown" types of notifications.

@LunaticMuch
Copy link
Author

This is what I get on a notification for a repo which is on a github enterprise

Screenshot 2023-09-27 at 14 30 33

@setchy
Copy link
Member

setchy commented Mar 12, 2024

I suspect in your situation, the following is either returning null, or a URL that is perhaps behind some network security controls

const avatarUrl = repoNotifications[0].repository.owner.avatar_url;

@LunaticMuch - you should be able to verify by calling /notifications and check what value is returned for repository.owner.avatar_url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants